-
-
Notifications
You must be signed in to change notification settings - Fork 450
Overhaul Address #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Kenzzer
wants to merge
7
commits into
master
Choose a base branch
from
virtual_address
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Overhaul Address #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2025
rtldg
reviewed
Feb 23, 2025
Can you also add this: } else if (vc->retinfo->vtype == Valve_VirtualAddress) {
void *addr = (void *)vc->retbuf;
return g_pSM->ToPseudoAddress(addr);
} else { to here sourcemod/extensions/sdktools/vcaller.cpp Lines 532 to 545 in b71d3c0
This would allow things like calling |
151ec78
to
7f8dfd6
Compare
4d69f79
to
ce846d4
Compare
I think this is great, and indeed much better than the define. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another Address PR!
The idea and implementation is primarily @dvander's, this PR just makes the bridge to SM.
In order to use the new virtual address :
If enabled, plugins need to ensure their SDKCalls are using the new
SDKType_VirtualAddress
, whether they're on 32bits or 64bits. Otherwise the plugin will most definitively crash the server.Marking as draft for now until I can get a few server operators to try this out. Extra natives idea are welcomed !