fix: char array to small to hold the firmware name#1
Open
hondagx35 wants to merge 1 commit intoallocom:masterfrom
hondagx35:master
Open
fix: char array to small to hold the firmware name#1hondagx35 wants to merge 1 commit intoallocom:masterfrom hondagx35:master
hondagx35 wants to merge 1 commit intoallocom:masterfrom
hondagx35:master
Conversation
The character array "firmware_name[40]" is to short to hold the firmware names for some settings. alloPiano/2.2/allo-piano-44100-100-0.bin => 41 characters including string terminator (\0) alloPiano/2.2/allo-piano-192000-100-0.bin => 42 characters including string terminator (\0)
|
Thanks. Please checkout driver from https://github.com/allocom/linux.git branch: rpi-piano for the latest driver. This issue is already addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The character array "firmware_name[40]" is to short to hold the firmware names for some settings.
alloPiano/2.2/allo-piano-44100-100-0.bin => 41 characters including string terminator (\0)
alloPiano/2.2/allo-piano-192000-100-0.bin => 42 characters including string terminator (\0)
ALSA crashes when changing settings (Lowpass higher the 90Hz).