Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add table name #349

Closed
wants to merge 1 commit into from

Conversation

OZoneGuy
Copy link

@OZoneGuy OZoneGuy commented Apr 19, 2023

Added a new option to the dynamic block to set the table name.

NOTE: this also contains changes from #348. Forgot to reset the branch when creating it :/

@alphapapa alphapapa force-pushed the master branch 2 times, most recently from 059b10c to 77b4c2b Compare December 16, 2023 13:55
@OZoneGuy OZoneGuy force-pushed the feat/keep-table-name branch 2 times, most recently from b363ad0 to c2477c9 Compare January 7, 2024 23:21
@alphapapa alphapapa added this to the 0.9 milestone Jan 8, 2024
@alphapapa alphapapa self-assigned this Jan 8, 2024
@alphapapa
Copy link
Owner

Sorry, but I will have to ask you to disentangle this and #348, as they both contain some of the same changes. Magit should make it easy enough; I'd suggest making a new branch and cherry-picking the changes, then pushing the new branch to this PR's reference.

@OZoneGuy
Copy link
Author

OZoneGuy commented Jan 8, 2024

Ah, looks like I forgot about this PR. Will make the changes soon. Do you prefer rebasing the changes, or are merge/revert commits ok?

@alphapapa
Copy link
Owner

It's always easiest to deal with a commit near the tip of the branch it's to be merged into, so rebasing is preferred. Sometimes I do the rebasing myself if necessary, but if you can, please do.

Allows the table to be referenced.
Optional string.
@jirijakes
Copy link

Thanks, @OZoneGuy, this would be useful!

Alternative solution might be to preserve lines starting with #+ during rendering, if that is possible.

In org-colview this is achieved by copying such lines from previous content, see https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/org-colview.el#n1666 :

(let ((content-lines (org-split-string (plist-get params :content) "\n")) recalc)
  ;; Insert affiliated keywords before the table.
  (when content-lines
    (while (string-match-p "\\`[ \t]*#\\+" (car content-lines))
      (insert (string-trim-left (pop content-lines)) "\n")))

@OZoneGuy
Copy link
Author

I am no longer using this tool and don't have time to work on this. If you wish, you are welcome to clone this and work on it.

@OZoneGuy OZoneGuy closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants