Skip to content

Add bottom overlay pill mode#310

Merged
altic-dev merged 4 commits intomainfrom
B/284-floating-tiny-overlay
Apr 30, 2026
Merged

Add bottom overlay pill mode#310
altic-dev merged 4 commits intomainfrom
B/284-floating-tiny-overlay

Conversation

@altic-dev
Copy link
Copy Markdown
Owner

Description

Adds a compact pill-sized bottom overlay mode and refines bottom/notch processing animations so the visualizer stays smooth during final transcription. Also removes the reserved bottom-overlay preview space when live preview is disabled.

Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update

Related Issues

  • N/A

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS 26.3
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources
  • Ran formatter locally: swiftformat --config .swiftformat Sources
  • Built locally: sh build_incremental.sh

Notes

  • Release notes updated locally under RELEASE_NOTES_1.5.13-beta.1.md; file is intentionally gitignored and not committed.
  • The bottom overlay processing status text is commented out for now so the visualizer shimmer carries the processing state.

Screenshots / Video

Not included; verified with local build/install/launch.

Use compositor-backed shimmer and stabilize bottom overlay layout during release so final ASR work does not stall the visible stop state.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aace78d552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/Fluid/ContentView.swift Outdated
@altic-dev
Copy link
Copy Markdown
Owner Author

@codex review

@altic-dev altic-dev merged commit 2e5cc9f into main Apr 30, 2026
2 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a01ae0fb01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1847 to +1849
if NotchOverlayManager.shared.isBottomOverlayVisible {
BottomOverlayWindowController.shared.beginReleaseTransition()
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate release transition to overlays that will be hidden

Calling beginReleaseTransition() before branching into command handling puts the bottom overlay into its dismissing state for every non-empty transcript, but the command path returns without hiding the overlay in stopAndProcessTranscription. In bottom-overlay command sessions this leaves isBottomOverlayDismissing active (faded/offset UI and suppressed preview) until some later unrelated hide event, so the overlay can look stuck in a near-hidden state during normal command usage. Move this transition to only the flows that immediately hide the overlay, or explicitly clear dismissing state when command processing completes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant