Conversation
Use compositor-backed shimmer and stabilize bottom overlay layout during release so final ASR work does not stall the visible stop state.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aace78d552
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a01ae0fb01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if NotchOverlayManager.shared.isBottomOverlayVisible { | ||
| BottomOverlayWindowController.shared.beginReleaseTransition() | ||
| } |
There was a problem hiding this comment.
Gate release transition to overlays that will be hidden
Calling beginReleaseTransition() before branching into command handling puts the bottom overlay into its dismissing state for every non-empty transcript, but the command path returns without hiding the overlay in stopAndProcessTranscription. In bottom-overlay command sessions this leaves isBottomOverlayDismissing active (faded/offset UI and suppressed preview) until some later unrelated hide event, so the overlay can look stuck in a near-hidden state during normal command usage. Move this transition to only the flows that immediately hide the overlay, or explicitly clear dismissing state when command processing completes.
Useful? React with 👍 / 👎.
Description
Adds a compact pill-sized bottom overlay mode and refines bottom/notch processing animations so the visualizer stays smooth during final transcription. Also removes the reserved bottom-overlay preview space when live preview is disabled.
Type of Change
Related Issues
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat Sourcessh build_incremental.shNotes
RELEASE_NOTES_1.5.13-beta.1.md; file is intentionally gitignored and not committed.Screenshots / Video
Not included; verified with local build/install/launch.