Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42148e7e78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for delay in [0.0, 0.12, 0.35, 1.0, 2.0, 4.0] { | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + delay) { [weak self] in | ||
| guard let self else { return } | ||
| guard delay == 0.0 || self.shouldContinueLaunchForegroundRetry() else { |
There was a problem hiding this comment.
Keep launch retries running until activation settles
The new guard delay == 0.0 || self.shouldContinueLaunchForegroundRetry() can prematurely stop all delayed foreground attempts even when the user has not switched apps, because NSApp.activate(ignoringOtherApps:) does not make NSApp.isActive true synchronously and frontmostApplication can still briefly report the previous app. In the common case where the main window is not yet created at 0.0s, the 0.12s retry may bail due to this transient state and the remaining retries are skipped, regressing the original startup behavior where retries were meant to wait for late window creation.
Useful? React with 👍 / 👎.
Description
Stops delayed startup foreground retries from reactivating FluidVoice after the user has already clicked into another app. The initial launch foreground behavior remains, but later retries now bail when FluidVoice is no longer active/frontmost.
Type of Change
Related Issues
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat Sourcessh build_incremental.shNotes
RELEASE_NOTES_1.5.13-beta.1.md; file is gitignored by design.self.references inHotkeyShortcut.swift.Screenshots / Video
Not included; behavior verified by local build/install/launch.