Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean History #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean History #1

wants to merge 1 commit into from

Conversation

ibamadd
Copy link

@ibamadd ibamadd commented Feb 25, 2015

Finalizing Solution

  • Removed loop for edge condition. Felt better to guarantee O(n) than randomness.
  • Added log4j support replacing sysout, created README, fixed edge case.
  • Added documentation and comments
  • Refactored method names
  • Cleaned up output
  • Simplified random generator
  • Exception on shuffling an empty deck
  • Turned off logging

randomness.

Finalizing Solution
* Added log4j support replacing sysout, created README, fixed edge case.
* Added documentation and comments
* Refactored method names
* Cleaned up output
* Simplified random generator
* Exception on shuffling an empty deck
* Turned off logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant