Add structure to retrieve patches and github method#8
Open
ThePseudo wants to merge 1 commit intoamarula:mainfrom
Open
Add structure to retrieve patches and github method#8ThePseudo wants to merge 1 commit intoamarula:mainfrom
ThePseudo wants to merge 1 commit intoamarula:mainfrom
Conversation
ThePseudo
force-pushed
the
patch-download
branch
5 times, most recently
from
e5cd2c6 to
bb53501
Compare
panicking
reviewed
May 19, 2025
Added structure to retrieve all the patches and the method to retrieve the data from Github. Signed-off-by: Andrea Calabrese <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, there is the skeleton of the patch-downloader module.
The various methods can be added inside the download_methods directory, remembering to add them similarly to how the Github method is implemented (adding both the check and the download functions to PATCH_DOWNLOAD_METHODS).
The API for calling the check and for the download of the patch is not set in stone yet, however I feel that right now this is all that is needed. It can be changed in the future, also with generic parameters, but I would prefer a finite and short set of arguments to the check and download functions.