xdna-driver CI #24
xdna-driver CI #24
Conversation
CI to run main flow
CI for PR authentication
| steps: | ||
| - name: Checkout private repository | ||
| if: ${{ github.event_name == 'pull_request_target' }} | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
To update to v4 everywhere I guess.
| gitExternalRepo: ${{ secrets.GIT_EXTERNAL_REPO }} | ||
|
|
||
| upload: | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
Is it interesting to upload in the case the workflow has been canceled?
There was a problem hiding this comment.
upload basically uploads the log file and internal users always want to see the log irrespective of whether the workflow is cancelled. The reason why we are uploading the log is because we are hiding the console output of the flow and routing it to a log file for internal use only.
There was a problem hiding this comment.
Good point. You could add this as a comment to enlighten the reader.
| jobs: | ||
| check: | ||
| runs-on: [ Ubuntu-22.04 ] | ||
| if: contains('amd-akshatah, kingtamamd, maxzhen, raphaelbamd, sonals, shirishjo ', format('{0},', github.actor)) && github.event.comment.body == '/build' && github.event.issue.pull_request |
There was a problem hiding this comment.
Since this is security-related and a bit convoluted, is this safe? It is unclear.
For example, if I have a user sonal or hisonals, does it work?
Relying on string conversion looks scary to me.
There was a problem hiding this comment.
Agreed, Let me check if I can add a group instead of string with a change in this logic.
|
I am curious about which kernel is actually used to run the CI. |
Production testing is separate. CI is just to sanity test the PR. As for the kernel, it will be close to latest released Linux kernel. |
CI source is not enabled by default. This will be enabled after the secrets are added , runners are added and internal repo is tested.