K8s object helm charts#57
Conversation
This commit introduces two new Helm charts, LimitRange and ResourceQuota, to the k8s-as-helm repository. It also updates the CI workflow to include helm-unittest for testing these new charts. Co-authored-by: cursor <cursor@exoatmospherics.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 18
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| continue | ||
| fi | ||
| if compgen -G "charts/${chart}/tests/*.yaml" > /dev/null; then | ||
| helm unittest "charts/${chart}" |
There was a problem hiding this comment.
CI script doubles chart path causing tests to never run
The ct list-changed command returns paths like charts/resourcequota, but the script prepends charts/ again in the compgen check and helm unittest command, creating invalid paths like charts/charts/resourcequota. This causes the unit test step to either always skip tests (if no matching path found) or fail (if attempting to run). The library chart exclusion check on line 43 also compares chart (which contains charts/lib-k8s-as-helm) against just lib-k8s-as-helm, so it will never match.
Additional Locations (1)
2 participants
Adds new Helm charts for
ResourceQuotaandLimitRangeKubernetes objects, including comprehensive unit tests, CI integration, and documentation, as requested in issue #44.Note
Introduces two new Kubernetes primitive charts and CI unit testing.
charts/resourcequotaandcharts/limitrangewithtemplates,_helpers.tpl,values.yaml,README.md, andNOTES.txtci/ci-values.yamland helm-unittest suites intests/*.yaml.github/workflows/ci.yamlto install thehelm-unittestplugin and run tests for changed charts (skipslib-k8s-as-helm)README.mdto mark and linkResourceQuotaandLimitRangeas supportedWritten by Cursor Bugbot for commit d2774d2. This will update automatically on new commits. Configure here.