fix: patch appdmg to use disk image path for hdiutil detach on macOS 15 arm64#169
Draft
haritabh-z01 with Copilot wants to merge 2 commits into
Draft
fix: patch appdmg to use disk image path for hdiutil detach on macOS 15 arm64#169haritabh-z01 with Copilot wants to merge 2 commits into
haritabh-z01 with Copilot wants to merge 2 commits into
Conversation
…macOS 15 On macOS 14/15 Sequoia arm64, the volume mount path captured from `hdiutil attach` (e.g. /Volumes/Amical) may become stale before the cleanup step runs, causing `hdiutil detach /Volumes/Amical` to fail with "No such file or directory". The disk image file path is stable and can always be used to detach the associated device. Changes: - patches/appdmg@0.6.6.patch: single-line fix in appdmg cleanup step to use global.temporaryImagePath (disk image path) instead of temporaryMountPath (volume mount path) for hdiutil detach - pnpm-workspace.yaml: migrate pnpm v10 settings (overrides, onlyBuiltDependencies, ignoredBuiltDependencies) from package.json pnpm field; add patchedDependencies for appdmg@0.6.6 - pnpm-lock.yaml: updated with patch hash for appdmg@0.6.6
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Build macOS (arm64)
fix: patch appdmg to use disk image path for hdiutil detach on macOS 15 arm64
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hdiutil detach /Volumes/Amicalfails with "No such file or directory" on macOS 15 Sequoia arm64. The volume mount path captured fromhdiutil attachbecomes stale before the cleanup step — disk arbitration can rename the volume to/Volumes/Amical 1while the image remains attached.Fix
Patch
appdmg@0.6.6(transitive dep viaelectron-installer-dmg→@fellow/maker-dmg) to detach by disk image file path instead of volume mount path.hdiutil detachaccepts a disk image path and resolves the device reliably regardless of volume name:pipeline.addCleanupStep('unmount-temporary-image', 'Unmounting temporary image', function (next) { - hdiutil.detach(temporaryMountPath, next) // /Volumes/Amical — can be renamed by macOS + hdiutil.detach(global.temporaryImagePath, next) // /tmp/xxx.dmg — always stable })Changes
patches/appdmg@0.6.6.patch— one-line fix in the cleanup callback of the "Mounting temporary image" pipeline steppnpm-workspace.yaml— addspatchedDependenciesforappdmg@0.6.6; also migrates pnpm v10 settings (overrides,onlyBuiltDependencies,ignoredBuiltDependencies) from the now-ignored"pnpm"field inpackage.jsonto the correct locationpnpm-lock.yaml— updated with patch hash (fed75697…) sopnpm install --frozen-lockfilevalidates and applies the patch