Skip to content

fix: vocabulary replacement fails for English words adjacent to CJK characters #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sysalpha01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: vocabulary replacement fails for English words adjacent to CJK characters #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/desktop/src/utils/text-replacement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ export function applyTextReplacements(
const regex = new RegExp(escapedWord, "giu");
result = result.replace(regex, replacement);
} else {
// Alphabetic languages: Use Unicode-aware word boundary matching
// Negative lookbehind/lookahead ensures word is not part of a larger word
// Alphabetic languages: Use word boundary matching
// Only check Latin script boundaries to prevent "apple" matching in "pineapple"
// but allow matching adjacent to CJK characters (e.g., "Xavixの設定")
const regex = new RegExp(
`(?<![\\p{L}\\p{N}])${escapedWord}(?![\\p{L}\\p{N}])`,
`(?<![\\p{Script=Latin}\\p{N}])${escapedWord}(?![\\p{Script=Latin}\\p{N}])`,
"giu",
);
result = result.replace(regex, replacement);
Expand Down