Open
Conversation
Closed
Author
|
Please make develop the default branch |
Author
|
And please review and merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements core transaction building and submission features for the Stellar SDK.
Key Changes:
transactionToXDR()andtransactionFromXDR()with validation and error handling for storage and retrieval.submitTransaction()on theStellarSDKclass with comprehensive mapping of Horizon error codes (e.g.,tx_bad_seq,op_underfunded, 504 timeouts) to typed SDK errors.buildCreateAccountOp()with an automated minimum reserve check to ensure funded accounts have at least the required 1.0 XLM.sdk-ci.ymlworkflow.Closes #122
Closes #119
Closes #115