feat: implement getEscrowBalance function#93
Open
yunus-dev-codecrafter wants to merge 1 commit intoamina69:mainfrom
Open
feat: implement getEscrowBalance function#93yunus-dev-codecrafter wants to merge 1 commit intoamina69:mainfrom
yunus-dev-codecrafter wants to merge 1 commit intoamina69:mainfrom
Conversation
Implements the escrow balance fetching feature for the escrow lifecycle epic.
Changes:
- Add getEscrowBalance() function to accept accountId and horizonUrl
- Validate accountId with isValidPublicKey()
- Fetch account from Horizon API
- Extract native (XLM) balance from balances array
- Return BalanceInfo: {accountId, balance, lastModifiedLedger}
- Throw EscrowNotFoundError on 404, ValidationError on invalid input
- Add comprehensive unit tests covering:
- Funded account with native balance
- Account with zero balance
- Account not found (404) error
- Invalid public key validation
- Other Horizon errors
- Network failures
- Export new function from SDK index
Labels: escrow, network, sdk
Size: XS (~2-4 hours)
|
@yunus-dev-codecrafter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@yunus-dev-codecrafter read the contributing .md before starting please, you are making pr to the wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #83
Quality Checks
✅ All 87 unit tests passing
✅ TypeScript compilation successful
✅ ESLint validation passed
✅ Type safety verified
Implements the escrow balance fetching feature for the escrow lifecycle epic.
Changes:
Labels: escrow, network, sdk
Size: XS (~2-4 hours)