Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use children.extend in Menu.add #892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wasinski
Copy link

Hi, I just started using this library via Litestar's plugin and I ran into an issue that only occurred when I was running tests of my application. When I have used the app normally then I could not get this error.

The error:

>               root.children.append(*item.children)
E               TypeError: list.append() takes exactly one argument (0 given)

It's raised when children are an empty list. Fix was easy, so I hope it's not expected that at that point children aren't empty, but if it was so, then probably a nicer error should be raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant