-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run formatting support #48
Conversation
@AleksanderVatov thanks for the PR! 😃
|
Will do. Can I combine this with the issue I wrote about, with the leading and trailing spaces in runs? As for the parameter name, I noticed that you don't include them in the header file, but here in particular I thought it might be a good idea because its purpose (as a combination of formatting flags) is otherwise unclear. I can then overload the & and | operators and use the FormattingFlags type. |
I overloaded the &, |, &=, and |= operators; now FormattingFlags can be used instead of int, and thus the parameter's name is no longer necessary in the header. I also added a sample. |
@amiremohamadi I have fixed #50 and implemented two new methods in another branch (https://github.com/AleksanderVatov/DuckX/tree/append_paragraph); please accept this PR first I'll make a new one for that branch. |
It's better to open separate pull-requests but I'll merge this pull-request soon |
I have implemented support for adding runs with formatting (bold, italic, underline, superscript, subscript, small caps, and shadow are supported).