Skip to content

Commit

Permalink
fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
amorynan committed Sep 3, 2024
1 parent cc7cce9 commit b55c560
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions be/src/vec/sink/writer/vtablet_writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1029,10 +1029,10 @@ static void* periodic_send_batch(void* writer) {
Status VTabletWriter::open(doris::RuntimeState* state, doris::RuntimeProfile* profile) {
// if we set enable_decimal_conversion=false && disable_decimalv2=false in config
// and we create nested type with decimal like array<text,decimal(28,12)>
// nereids planner will throw exception with precision should in (0, 27], but real precision is 28
// nereids planner will throw exception with precision should in (0, 27], but real precision is 28
// but in 2.1 we can fall back to old planner which make this behavior possible
// so in _init() we will meet slot has decimalv2 type with has precision 28 and exception will
// throw from func check_type_precision() , so here we catch exception to avoid be core.
// so in _init() we will meet slot has decimalv2 type with has precision 28 and exception will
// throw from func check_type_precision() , so here we catch exception to avoid be core.
RETURN_IF_ERROR_OR_CATCH_EXCEPTION(_init(state, profile));
signal::set_signal_task_id(_load_id);
SCOPED_TIMER(profile->total_time_counter());
Expand Down
6 changes: 3 additions & 3 deletions be/src/vec/sink/writer/vtablet_writer_v2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,10 @@ Status VTabletWriterV2::_init(RuntimeState* state, RuntimeProfile* profile) {
Status VTabletWriterV2::open(RuntimeState* state, RuntimeProfile* profile) {
// if we set enable_decimal_conversion=false && disable_decimalv2=false in config
// and we create nested type with decimal like array<text,decimal(28,12)>
// nereids planner will throw exception with precision should in (0, 27], but real precision is 28
// nereids planner will throw exception with precision should in (0, 27], but real precision is 28
// but in 2.1 we can fall back to old planner which make this behavior possible
// so in _init() we will meet slot has decimalv2 type with has precision 28 and exception will
// throw from func check_type_precision() , so here we catch exception to avoid be core.
// so in _init() we will meet slot has decimalv2 type with has precision 28 and exception will
// throw from func check_type_precision() , so here we catch exception to avoid be core.
RETURN_IF_ERROR_OR_CATCH_EXCEPTION(_init(state, profile));
LOG(INFO) << "opening olap table sink, load_id=" << print_id(_load_id) << ", txn_id=" << _txn_id
<< ", sink_id=" << _sender_id;
Expand Down

0 comments on commit b55c560

Please sign in to comment.