-
Notifications
You must be signed in to change notification settings - Fork 51
chore: playwright remote config smoke tests #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daniel-graham-amplitude
merged 13 commits into
main
from
AMP-138747/playwright-remote-config-smoke-test
Sep 16, 2025
Merged
chore: playwright remote config smoke tests #1277
daniel-graham-amplitude
merged 13 commits into
main
from
AMP-138747/playwright-remote-config-smoke-test
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercy811
reviewed
Sep 2, 2025
packages/e2e-remote-config/test/e2e/fetch-remote-config.spec.ts
Outdated
Show resolved
Hide resolved
4345a47
to
2d065c9
Compare
2d065c9
to
23c26e8
Compare
Mercy811
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a bash script that runs a round of playwright tests against the local server. These tests test that the remote config endpoint is being called and that after calling "init" the page is still interactable. They run across a matrix of different API keys and server zones (staging + us)
Checklist