chore: migrate network tracking to zen observable #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tude-TypeScript into no-ticket-zen-observable-dead-click
…tude-TypeScript into no-ticket-zen-observable-dead-click
Base automatically changed from
no-ticket-zen-observable
to
zen-observable-migration
October 30, 2025 03:29
…tude-TypeScript into no-ticket-zen-observable-dead-click
Co-authored-by: Copilot <[email protected]>
…ack-dead-click.test.ts Co-authored-by: Copilot <[email protected]>
…ack-dead-click.test.ts Co-authored-by: Copilot <[email protected]>
…itude/Amplitude-TypeScript into AMP-142601-migrate-network-tracking-to-zen-observable
…tude-TypeScript into AMP-142601-migrate-network-tracking-to-zen-observable
Dogfalo
approved these changes
Oct 31, 2025
Mercy811
approved these changes
Oct 31, 2025
There was a problem hiding this comment.
Just notes for myself: it makes sense to delete subscriptions as we only push one to it.
There was a problem hiding this comment.
Yeah I had originally copy-pasted this logic from another autocapture (which had several subscriptions) to network capture. Didn't realize that network only had the one subscription.
daniel-graham-amplitude
merged commit 82f0e00
into
zen-observable-migration
8 checks passed
daniel-graham-amplitude
deleted the
AMP-142601-migrate-network-tracking-to-zen-observable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove RxJS from "plugin-network-capture-browser"
Checklist