Skip to content

GSDK-578: add support for mobile g&s theme typography #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

GSDK-578: add support for mobile g&s theme typography #1054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
014d002
GSDK-578: add support for mobile g&s typography
bmcurutan Oct 3, 2025
0d5eccb
Update themes.md
JeffScattini-amplitude Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions content/collections/guides_and_surveys/en/themes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,29 @@

### Typography

Set the default type face of your theme. Choose from the [Google font library](https://fonts.google.com/), or specify a custom type face you've already defined on your site.
Set the default typeface of your theme. Choose from the [Google font library](https://fonts.google.com/), or specify a custom typeface you've already defined on your site.

To use a font natively in your mobile Guides and Surveys, be sure to include the full font family in your app project and use a consistent file name for the font.

Check warning on line 63 in content/collections/guides_and_surveys/en/themes.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Microsoft.SentenceLength] Try to keep sentences short (< 30 words).

Raw Output:
{"message": "[Microsoft.SentenceLength] Try to keep sentences short (\u003c 30 words).", "location": {"path": "content/collections/guides_and_surveys/en/themes.md", "range": {"start": {"line": 63, "column": 1}}}, "severity": "INFO"}

#### Android
- Place font files in the `/res/font` directory of your project.
- Use a clear and consistent naming convention:
- `[fontName]_[style].[fileExtension]`
- For example: `lora_italic.ttf`
- Supported formats: **XML**, **TTF**.

Check warning on line 70 in content/collections/guides_and_surveys/en/themes.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Microsoft.Acronyms] 'TTF' has no definition.

Raw Output:
{"message": "[Microsoft.Acronyms] 'TTF' has no definition.", "location": {"path": "content/collections/guides_and_surveys/en/themes.md", "range": {"start": {"line": 70, "column": 33}}}, "severity": "INFO"}
- After adding, the font can be referenced directly in your theme setup.

Check warning on line 71 in content/collections/guides_and_surveys/en/themes.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Microsoft.Passive] 'be referenced' looks like passive voice.

Raw Output:
{"message": "[Microsoft.Passive] 'be referenced' looks like passive voice.", "location": {"path": "content/collections/guides_and_surveys/en/themes.md", "range": {"start": {"line": 71, "column": 30}}}, "severity": "INFO"}

For more information, go to Android's [Font resources](https://developer.android.com/guide/topics/resources/font-resource).

#### iOS

Check warning on line 75 in content/collections/guides_and_surveys/en/themes.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Microsoft.Headings] 'iOS' should use sentence-style capitalization.

Raw Output:
{"message": "[Microsoft.Headings] 'iOS' should use sentence-style capitalization.", "location": {"path": "content/collections/guides_and_surveys/en/themes.md", "range": {"start": {"line": 75, "column": 6}}}, "severity": "INFO"}
- Add font files to your Xcode project.
- Use a clear and consistent naming convention:
- `[FontName]-[Style].[fileExtension]`
- For example: `Lora-Italic.ttf`
- Register the fonts in your app's `.plist` file.
- Supported formats: **TTF**, **OTF**.

Check warning on line 81 in content/collections/guides_and_surveys/en/themes.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Microsoft.Acronyms] 'OTF' has no definition.

Raw Output:
{"message": "[Microsoft.Acronyms] 'OTF' has no definition.", "location": {"path": "content/collections/guides_and_surveys/en/themes.md", "range": {"start": {"line": 81, "column": 33}}}, "severity": "INFO"}

Check warning on line 81 in content/collections/guides_and_surveys/en/themes.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Microsoft.Acronyms] 'TTF' has no definition.

Raw Output:
{"message": "[Microsoft.Acronyms] 'TTF' has no definition.", "location": {"path": "content/collections/guides_and_surveys/en/themes.md", "range": {"start": {"line": 81, "column": 24}}}, "severity": "INFO"}

For more information, go to Apple's [Adding a custom font to your app](https://developer.apple.com/documentation/uikit/adding-a-custom-font-to-your-app).

{{partial:admonition type="note" heading="Font previews"}}
Custom fonts you add that aren't part of Google Fonts don't appear in the theme preview.
Expand Down Expand Up @@ -142,4 +164,4 @@

Components are reusable elements that you use across your guides and surveys. With components, you only specify the contents once, and then can apply them anywhere in the theme.

Each component includes states, for example default, hover, or focus, that you can customize.
Each component includes states, for example default, hover, or focus, that you can customize.
Loading