Skip to content

feat: New exposure method to specify variant and payload #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: New exposure method to specify variant and payload #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/Experiment/ExperimentClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import Foundation
@objc func variant(_ key: String, fallback: Variant?) -> Variant
@objc func all() -> [String:Variant]
@objc func exposure(key: String)
@objc func exposure(key: String, variant: String, payload: Any?)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@objc func exposure(key: String, variant: Variant)
To better match the rest of the API. Tt looks strange to pass a String instead of an actual Variant.

@objc func setUser(_ user: ExperimentUser?)
@objc func getUser() -> ExperimentUser?
@objc func clear()
Expand Down Expand Up @@ -211,6 +212,11 @@ internal class DefaultExperimentClient : NSObject, ExperimentClient {
let variantAndSource = variantAndSource(key: key, fallback: nil)
exposureInternal(key: key, variantAndSource: variantAndSource)
}

public func exposure(key: String, variant: String, payload: Any?) {
let variantAndSource = VariantAndSource(variant: Variant(variant, payload: payload))
exposureInternal(key: key, variantAndSource: variantAndSource)
}

public func getUser() -> ExperimentUser? {
return self.user
Expand Down
Loading