-
Notifications
You must be signed in to change notification settings - Fork 504
Make amp-sidebar sample validate #167
Comments
CC @andrewwatterson -- this is the UI issue I was discussing with you at the Amp Conf in Tokyo today. I went to file an issue and found this one, plus the other two, outstanding from a couple years ago. For some context, this was the Stack Overflow question I asked a couple years back: https://stackoverflow.com/questions/39857415/amp-sidebar-does-it-absolutely-have-to-be-the-child-of-the-body-why At the time, @cramforce had filed this tweet: https://twitter.com/cramforce/status/783352472014233600 What I'm wondering is: Are there still valid reasons for not allowing amp-sidebar to be anything else other than the child of the body? Something else that's this confusing -- on the amp-sidebar docks: https://amp.dev/documentation/examples/components/amp-sidebar/ The example seems to be a child of a |
Unrelated, but your live coding session was awesome! :D |
(Last note) it does appear as if the docs are incorrect -- Thanks all! |
cc @ampproject/wg-ui-and-a11y |
amp-sidebar requires that the sidebar is the first element after the body tag. With ABE's column layout this is not possible. We need to find a way to move the amp-sidebar there in the generated sample. Currently, it still works but doesn't validate.
The text was updated successfully, but these errors were encountered: