AutoExtensionImporter: Append extension scripts after runtime script #1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
AutoExtensionImporter
transformer adds the needed extension scripts after the viewport node.However, this creates markup where the head contains all extension scripts first, then the boilerplate style, and then the runtime. In terms of priorities, this seems backwards. Why load the extensions if the runtime itself is not yet registered?
This PR changes the transformer so that it first tries to append the extension scripts after an existing runtime script, and only falls back to using the viewport as a reference node if no runtime script was found.
before:
after: