Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update means of determining bento support for component #6373

Merged
merged 5 commits into from
Jun 16, 2021

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jun 11, 2021

Summary

Blocked on the required change being made in https://github.com/ampproject/amphtml/blob/main/build-system/compile/bundles.config.extensions.json

Accounts for change in ampproject/amphtml#34838.

Also includes changes from ampproject/amphtml#34798.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1.3 milestone Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #6373 (0b72eef) into develop (8a42c7b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6373      +/-   ##
=============================================
+ Coverage      75.39%   75.44%   +0.04%     
- Complexity      5881     5894      +13     
=============================================
  Files            235      235              
  Lines          17786    17823      +37     
=============================================
+ Hits           13410    13446      +36     
- Misses          4376     4377       +1     
Flag Coverage Δ
javascript 79.84% <ø> (ø)
php 75.24% <ø> (+0.04%) ⬆️
unit 75.24% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/sanitizers/class-amp-allowed-tags-generated.php 46.42% <ø> (ø)
assets/src/common/helpers/index.js 91.52% <0.00%> (ø)
assets/src/block-editor/helpers/index.js 39.28% <0.00%> (ø)
assets/src/block-editor/store/selectors.js 100.00% <0.00%> (ø)
src/PairedRouting.php 96.32% <0.00%> (+0.11%) ⬆️

@github-actions
Copy link
Contributor

Plugin builds for 0b72eef are ready 🛎️!

@westonruter westonruter merged commit 9559588 into develop Jun 16, 2021
@westonruter westonruter deleted the update/bento-component-determination branch June 16, 2021 22:08
@westonruter westonruter self-assigned this Jul 1, 2021
@westonruter
Copy link
Member Author

QA Passed

The components which are currently marked as having Bento components available include:

  1. amp-accordion
  2. amp-base-carousel
  3. amp-date-countdown
  4. amp-date-display
  5. amp-facebook-like
  6. amp-fit-text
  7. amp-inline-gallery
  8. amp-instagram
  9. amp-lightbox
  10. amp-render
  11. amp-selector
  12. amp-social-share
  13. amp-stream-gallery
  14. amp-timeago
  15. amp-twitter
  16. amp-video
  17. amp-video-iframe
  18. amp-vimeo
  19. amp-youtube

Note that amp-facebook-like will be removed for now via #6436 (due to ampproject/amphtml#35046) but this isn't critical since we're not using the Bento specs yet anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants