Use amp-tiktok for TikTok instead of amp-embedly-card
#6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 4d03ae7 are ready 🛎️!
|
pierlon
reviewed
Aug 25, 2021
Comment on lines
140
to
142
| if ( version_compare( '5.4-alpha', get_bloginfo( 'version' ), '>' ) ) { | ||
| $this->markTestSkipped( 'The TikTok embed is only available in 5.4-alpha (until 5.4 is stable)' ); | ||
| } |
There was a problem hiding this comment.
This can now be removed now that the TikTok embed is generally available in WP.
There was a problem hiding this comment.
It's not available in older versions of WP still, right?
There was a problem hiding this comment.
Support for TikTok was added in WP 5.4: https://core.trac.wordpress.org/ticket/49083
So in versions older than 5.4 we wouldn't want to test this.
There was a problem hiding this comment.
Ah right, we could update the message then.
Co-authored-by: Pierre Gordon <[email protected]>
pierlon
reviewed
Aug 25, 2021
Comment on lines
140
to
142
| if ( version_compare( '5.4-alpha', get_bloginfo( 'version' ), '>' ) ) { | ||
| $this->markTestSkipped( 'The TikTok embed is only available in 5.4-alpha (until 5.4 is stable)' ); | ||
| } |
There was a problem hiding this comment.
Ah right, we could update the message then.
Co-authored-by: Pierre Gordon <[email protected]>
pierlon
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Other than the layout shifting reported in ampproject/amphtml#35789, this looks good 👍.
westonruter
added a commit
that referenced
this pull request
Aug 25, 2021
Co-authored-by: Pierre Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See ampproject/amphtml#32219.
Fixes #6060.
Embeds can be added via the TikTok block:
No validation errors result:
Checklist