Update amphtml spec to 2110152252000 #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging f842725 into 65cdda6 - view on LGTM.com new alerts:
|
|
Plugin builds for 2274744 are ready 🛎️!
|
swissspidy
reviewed
Oct 19, 2021
| @@ -1384,6 +1384,7 @@ public function test_amp_register_default_scripts_and_styles() { | |||
| 'amp-story-360' => 'v0/amp-story-360-0.1.js', | |||
| 'amp-story-auto-ads' => 'v0/amp-story-auto-ads-0.1.js', | |||
| 'amp-story-auto-analytics' => 'v0/amp-story-auto-analytics-0.1.js', | |||
| 'amp-story-captions' => 'v0/amp-story-captions-0.1.js', | |||
westonruter
changed the title
pierlon
approved these changes
Oct 19, 2021
| 'requires_extension' => array( | ||
| 'amp-story-captions', | ||
| ), | ||
| 'spec_url' => 'https://amp.dev/documentation/components/amp-story-captions', |
There was a problem hiding this comment.
Just noting there's no documentation page for this extension.
There was a problem hiding this comment.
I think it's just because a deploy on amp.dev hasn't been done yet.
6 tasks
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #6530.
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml').Modify validating sanitizer based on changes to spec, if needed.Changelog
bentoflag inbundles.config.extensions.json.amp-story-captions.amp-story-page-attachment:amp-selector,datalist,fieldset,form,input,label,legend,meter,optgroup,option,output,progress,select,textarea.amp-story-panning-mediaand enforceamp-imgchild.amp-embedly-card,amp-iframe,amp-mathml,amp-sidebar,amp-soundcloud, andamp-wordpress-embed.noscript[amp-noscript] > style, although the script sanitizer and style sanitizer aren't currently updated to persist it. See Add support for no-JS styling andnoscript > style[amp-noscript]#6603.Details
( PREV_VERSION=dc6cd22a52; THIS_VERSION=2110152252000; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- build-system/compile/bundles.config.extensions.json $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null ) | sed '/-#/d'Diff dc6cd22...530a457