-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Sandboxing #6715
Merged
Merged
Improve Sandboxing #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
ce9b0f3
to
621a79d
Compare
Plugin builds for 61ec39d are ready 🛎️!
|
dhaval-parekh
approved these changes
Nov 16, 2021
Changes look good to me. 👍 |
milindmore22
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
QA Passed Sanboxing settings are moved to the new drawer, AMP sandboxing levels are working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to #6546. Namely, it seeks to address key Future Todos.
Changes
Sandboxing::finalize_document()
if the experiment is not enabled. See Experimental: Add sandboxing levels #6546 (comment).v0.js
andv0.mjs
), AMP runtime style, and AMP CDN preconnectlink
if they are not needed due to no other AMP scripts being on the page and valid AMP is not the target (level 3).comment-reply
script when there isn't a comment form on the page. (Hestia is enqueueing this script wheneveris_singular()
and isn't checking ifcomments_open() && get_option( 'thread_comments' )
.)Checklist