Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support amp-facebook-comments, -like, and -page with one extension binary (1.0 only) #35064

Merged
merged 13 commits into from
Jul 26, 2021
Merged

Support amp-facebook-comments, -like, and -page with one extension binary (1.0 only) #35064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d2bb53d
Support all attrs in amp-facebook
caroqliu Jun 25, 2021
ac59c2a
Move Storybook examples under amp-facebook
caroqliu Jun 25, 2021
647b4a0
Move to amp-facebook extension
caroqliu Jun 25, 2021
d83468c
Move test files
caroqliu Jun 25, 2021
e8d87d7
Remove dependency allowlist entries
caroqliu Jun 25, 2021
74ec25f
Merge branch 'main' into single-amp-facebook
caroqliu Jul 9, 2021
778c95f
Update unit test
caroqliu Jul 9, 2021
d628a1a
Attempt adding validations
caroqliu Jul 9, 2021
5217131
Merge branch 'main' into single-amp-facebook
caroqliu Jul 20, 2021
fee6773
Merge branch 'main' into single-amp-facebook
caroqliu Jul 26, 2021
4c25463
Revert validator changes
caroqliu Jul 26, 2021
05f0a31
Remove extra line
caroqliu Jul 26, 2021
cfc5743
Add space
caroqliu Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions build-system/compile/bundles.config.extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,42 +370,16 @@
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-facebook-comments",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"wrapper": "bento"
}
},
{
"name": "amp-facebook-like",
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-facebook-like",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"hasCss": true,
"wrapper": "bento"
}
},
{
"name": "amp-facebook-page",
"version": "0.1",
"latestVersion": "0.1"
},
{
"name": "amp-facebook-page",
"version": "1.0",
"latestVersion": "0.1",
"options": {
"hasCss": true,
"wrapper": "bento"
}
},
{
"name": "amp-fit-text",
"version": "0.1",
Expand Down
6 changes: 0 additions & 6 deletions build-system/test-configs/dep-check-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,6 @@ exports.rules = [
'extensions/amp-facebook/1.0/amp-facebook.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-page/0.1/amp-facebook-page.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-comments/0.1/amp-facebook-comments.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-comments/1.0/amp-facebook-comments.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-comments/1.0/base-element.js->extensions/amp-facebook/1.0/facebook-base-element.js',
'extensions/amp-facebook-like/1.0/amp-facebook-like.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-like/1.0/base-element.js->extensions/amp-facebook/1.0/facebook-base-element.js',
'extensions/amp-facebook-page/1.0/amp-facebook-page.js->extensions/amp-facebook/0.1/facebook-loader.js',
'extensions/amp-facebook-page/1.0/base-element.js->extensions/amp-facebook/1.0/facebook-base-element.js',

// VideoBaseElement, VideoIframe and VideoWrapper are meant to be shared.
'extensions/**->extensions/amp-video/1.0/video-base-element.js',
Expand Down
38 changes: 0 additions & 38 deletions extensions/amp-facebook-comments/1.0/amp-facebook-comments.css
View file
Open in desktop

This file was deleted.

74 changes: 0 additions & 74 deletions extensions/amp-facebook-comments/1.0/amp-facebook-comments.js
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions extensions/amp-facebook-comments/1.0/base-element.js
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions extensions/amp-facebook-comments/1.0/storybook/Basic.amp.js
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions extensions/amp-facebook-like/1.0/amp-facebook-like.css
View file
Open in desktop

This file was deleted.

79 changes: 0 additions & 79 deletions extensions/amp-facebook-like/1.0/amp-facebook-like.js
View file
Open in desktop

This file was deleted.

Loading