✨ Add channelid Attribute to <amp-youtube> Component #40252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@rbeckthomas could you review this? |
refactor: clean up debug logs
chore: improve wording in error messages
|
there seems to be some unrelated test failures. ill try to figure the issue out or skip it if needed. please give me a day or two to look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26304
Summary
This PR adds support for the channelid attribute in the component, allowing users to embed the latest video from a specified YouTube channel.
Currently, supports embedding individual videos and playlists but does not allow embedding a channel’s latest video dynamically. This update enables users to specify a channelid, which will automatically load and display the most recent video from that channel.
Changes Introduced
Added a channelid attribute to .
Implemented logic to construct the correct embed URL for displaying the latest video from the channel.
Testing
Manually tested with different channelid values to ensure the latest video loads correctly.
Updated automated tests to validate expected behaviour.