Skip to content

Feature/drop using bitsyntax pkg #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 29, 2025

Conversation

ikenfin
Copy link
Contributor

@ikenfin ikenfin commented Mar 20, 2025

Drop using @acuminous/bitsyntax because it's incompatible with --disallow-code-generation-from-strings node flag, and there is no heavy bit parsing logic which cannot be replaced with some simple code

@cressie176
Copy link
Collaborator

Hi @ikenfin,
Thank you for this. amqplib currently supports Node 0.10 onwards. Is there anything in this PR which couldn't be made compatible with this?

@ikenfin
Copy link
Contributor Author

ikenfin commented Mar 20, 2025

Hi @cressie176 !
My bad. I will look how to bring backward compatibility with so legacy node and send update, thanks!

@ikenfin
Copy link
Contributor Author

ikenfin commented Mar 21, 2025

@cressie176 Seems i've fixed compatibility issues, now all tests are report ok

@cressie176 cressie176 merged commit 212c02c into amqp-node:main Mar 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants