Add variables and comments #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webseed update timer
Close body in same go routine as do
anacrolix
reviewed
May 8, 2024
| if restart { | ||
| goto start | ||
|
|
||
| if !restart { |
There was a problem hiding this comment.
Something here doesn't feel right. I don't think this part of the code should be determining if updating is appropriate. Sorry to block on this so long, but a lot of the other changes seem worthwhile so I'm trying to minimize this change to a minimum so it can make sense in isolation.
There was a problem hiding this comment.
@mh0lt let's break it to 2 PR's?
There was a problem hiding this comment.
If you rebase you should find less changes are needed too. Thanks for your efforts.
| @@ -142,6 +172,7 @@ func (ws *webseedPeer) handleUpdateRequests() { | |||
| ws.peer.t.cl.lock() | |||
| defer ws.peer.t.cl.unlock() | |||
| ws.peer.maybeUpdateActualRequestState() | |||
| ws.requesterCond.Signal() | |||
There was a problem hiding this comment.
This looks like it's very likely appropriate.
|
I think this is related to #932 (comment) and the same reasoning applies. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional comments and variables for:
41fc76a