setup: lint + fmt + ci + dependabot#11
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## Walkthrough
This update removes all ESLint-related configuration and dependencies from the project, replacing them with Biome for linting and formatting. New configuration files for Biome and EditorConfig are introduced, and a GitHub Actions workflow is added for automated linting and formatting. All code files are reformatted for consistent indentation and style, with no changes to logic or functionality.
## Changes
| File(s) | Change Summary |
|----------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `.editorconfig`, `biome.jsonc` | Added new configuration files for EditorConfig and Biome to enforce consistent code style, formatting, and linting across the project. |
| `.github/dependabot.yml`, `.github/workflows/ci.yml` | Added Dependabot configuration for automated dependency updates and a GitHub Actions workflow for running Biome lint/format checks on pull requests and pushes to `main`. |
| `.prettierignore` | Deleted; Prettier ignore rules removed as Prettier is no longer the primary formatter. |
| `package.json` | Updated scripts to use Biome for linting and formatting; added Biome to devDependencies; adjusted script names and added a pre-commit hook. |
| `apps/web/package.json`, `packages/api/package.json`, `packages/auth/package.json`, `packages/db/package.json`, `packages/env/package.json` | Removed ESLint-related scripts and devDependencies from package.json files across all packages. |
| `tooling/eslint-config/base.js`, `tooling/eslint-config/next.js`, `tooling/eslint-config/react.js`, `tooling/eslint-config/package.json` | Deleted all shared ESLint configuration files and their package.json. |
| `apps/web/eslint.config.mjs`, `packages/api/eslint.config.mjs`, `packages/auth/eslint.config.mjs`, `packages/db/eslint.config.mjs`, `packages/env/eslint.config.mjs` | Deleted package-level ESLint configuration files that previously re-exported shared configs. |
| All `tsconfig.json` and related tooling configs | Added or removed trailing newlines for formatting consistency; no changes to configuration content. |
| All source code files (`apps/web/...`, `packages/api/...`, `packages/auth/...`, `packages/db/...`, `packages/env/...`, `packages/google-calendar/...`) | Reformatted all code to use consistent indentation (tabs instead of spaces), adjusted line breaks, normalized import/export style (including more use of `import type`), and made other style-only changes. No logic, control flow, or API changes. |
| `turbo.json` | Removed extraneous spaces inside environment variable arrays for task configuration. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant Developer
participant Biome CLI
participant GitHub Actions
participant Repository
Developer->>Biome CLI: Run lint/format scripts (biome lint ./, biome format ./)
Biome CLI->>Developer: Outputs lint/format results
Developer->>Repository: Push code / open PR
Repository->>GitHub Actions: Triggers CI workflow (ci.yml)
GitHub Actions->>Biome CLI: Setup and run `biome ci .`
Biome CLI->>GitHub Actions: Outputs lint/format results
GitHub Actions->>Repository: Reports status (pass/fail)Assessment against linked issues
Poem
|
There was a problem hiding this comment.
Pull Request Overview
This PR sets up a new development workflow by replacing the ESLint/Prettier setup with Biome, adding a CI pipeline and Dependabot configuration. Key changes include updated import style across components, removal of ESLint and Prettier configuration files, and the introduction of new CI and dependency update workflows.
Reviewed Changes
Copilot reviewed 103 out of 103 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/lib/trpc/client.tsx | Consolidated import formatting for clarity. |
| apps/web/src/components/ui/label.tsx | Changed React import to a type-only import and simplified the component props. |
| apps/web/src/components/ui/input.tsx | Updated React import to a type-only import. |
| apps/web/src/components/ui/card.tsx | Refactored component returns and export statement formatting. |
| apps/web/src/components/ui/button.tsx | Adjusted formatting for button variant definitions and imports. |
| apps/web/src/components/icons/google.tsx | Reformatted self-closing SVG path tags. |
| apps/web/src/app/page.tsx | Enforced consistent semicolon usage and simplified JSX. |
| apps/web/src/app/layout.tsx | Streamlined RootLayout component formatting. |
| apps/web/src/app/api/trpc/[trpc]/route.ts | Improved logging format by adjusting indentation in console output. |
| apps/web/src/app/(auth)/login/sign-in-form.tsx | Cleaned up JSX indentation and merged duplicate className strings. |
| apps/web/package.json | Removed the lint script and ESLint dependencies; start script remains intact. |
| apps/web/eslint.config.mjs | Removed obsolete ESLint configuration. |
| .prettierignore | Removed Prettier ignore settings. |
| .github/workflows/ci.yml | Introduced a new CI workflow with Biome for linting and formatting. |
| .github/dependabot.yml | Added Dependabot configuration for GitHub Actions and npm dependencies. |
| .editorconfig | Added a new editor configuration to enforce consistent code style. |
Comments suppressed due to low confidence (2)
apps/web/package.json:7
- Confirm the removal of the lint script and ESLint dependencies is intentional, and ensure that Biome is configured to cover all necessary linting and formatting rules.
"lint": "next lint"
.prettierignore:1
- Verify that removing the .prettierignore file is a deliberate choice and that any formatting rules it enforced have been fully migrated to the new formatting setup.
node_modules
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
package.json (1)
18-21: Cleanup unused Prettier dependency
Prettier remains listed indevDependencieseven though formatting is now handled by Biome and the Prettier config files have been removed. Consider removing"prettier"to avoid confusion and keep dependencies minimal..github/workflows/ci.yml (1)
1-25: Solid CI workflow implementation!The GitHub Actions workflow is well-structured with:
- Proper triggers for pull requests and pushes to main
- Security hardening with step-security
- Pinned action versions with commit hashes (good security practice)
- Appropriate Biome setup and linting command
Consider adding dependency caching to speed up CI runs:
- name: Lint with Biome uses: biomejs/setup-biome@c016c38f26f2c4a6eb3662679143614a254263fd # v2.3.0 with: version: latest + - name: Cache node_modules + uses: actions/cache@v4 + with: + path: '**/node_modules' + key: ${{ runner.os }}-modules-${{ hashFiles('**/package-lock.json') }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (2)
bun.lockis excluded by!**/*.lockbun.lockbis excluded by!**/bun.lockb
📒 Files selected for processing (100)
.editorconfig(1 hunks).github/dependabot.yml(1 hunks).github/workflows/ci.yml(1 hunks).prettierignore(0 hunks)apps/web/eslint.config.mjs(0 hunks)apps/web/next.config.ts(1 hunks)apps/web/package.json(1 hunks)apps/web/src/app/(auth)/login/page.tsx(1 hunks)apps/web/src/app/(auth)/login/sign-in-form.tsx(1 hunks)apps/web/src/app/api/trpc/[trpc]/route.ts(1 hunks)apps/web/src/app/globals.css(1 hunks)apps/web/src/app/layout.tsx(1 hunks)apps/web/src/app/page.tsx(1 hunks)apps/web/src/app/providers.tsx(1 hunks)apps/web/src/components/icons/google.tsx(1 hunks)apps/web/src/components/ui/button.tsx(1 hunks)apps/web/src/components/ui/card.tsx(1 hunks)apps/web/src/components/ui/input.tsx(1 hunks)apps/web/src/components/ui/label.tsx(1 hunks)apps/web/src/lib/trpc/client.tsx(2 hunks)apps/web/src/lib/trpc/query-client.tsx(1 hunks)apps/web/src/lib/trpc/server.tsx(2 hunks)apps/web/src/lib/utils.ts(1 hunks)apps/web/tsconfig.json(1 hunks)biome.jsonc(1 hunks)package.json(1 hunks)packages/api/eslint.config.mjs(0 hunks)packages/api/package.json(1 hunks)packages/api/src/root.ts(1 hunks)packages/api/src/routers/user.ts(1 hunks)packages/api/src/trpc.ts(2 hunks)packages/api/tsconfig.json(1 hunks)packages/auth/eslint.config.mjs(0 hunks)packages/auth/package.json(1 hunks)packages/auth/src/server.ts(1 hunks)packages/auth/tsconfig.json(1 hunks)packages/db/drizzle.config.ts(1 hunks)packages/db/eslint.config.mjs(0 hunks)packages/db/package.json(1 hunks)packages/db/src/schema/auth.ts(1 hunks)packages/db/tsconfig.json(1 hunks)packages/env/eslint.config.mjs(0 hunks)packages/env/package.json(1 hunks)packages/env/src/client.ts(1 hunks)packages/env/src/server.ts(1 hunks)packages/env/tsconfig.json(1 hunks)packages/google-calendar/src/client.ts(2 hunks)packages/google-calendar/src/core/api-promise.ts(1 hunks)packages/google-calendar/src/core/error.ts(1 hunks)packages/google-calendar/src/core/resource.ts(1 hunks)packages/google-calendar/src/core/uploads.ts(1 hunks)packages/google-calendar/src/index.ts(1 hunks)packages/google-calendar/src/internal/builtin-types.ts(4 hunks)packages/google-calendar/src/internal/detect-platform.ts(2 hunks)packages/google-calendar/src/internal/errors.ts(1 hunks)packages/google-calendar/src/internal/headers.ts(2 hunks)packages/google-calendar/src/internal/parse.ts(1 hunks)packages/google-calendar/src/internal/qs/formats.ts(1 hunks)packages/google-calendar/src/internal/qs/index.ts(1 hunks)packages/google-calendar/src/internal/qs/stringify.ts(1 hunks)packages/google-calendar/src/internal/qs/types.ts(1 hunks)packages/google-calendar/src/internal/qs/utils.ts(1 hunks)packages/google-calendar/src/internal/request-options.ts(1 hunks)packages/google-calendar/src/internal/shim-types.d.ts(1 hunks)packages/google-calendar/src/internal/shims.ts(2 hunks)packages/google-calendar/src/internal/to-file.ts(2 hunks)packages/google-calendar/src/internal/types.ts(2 hunks)packages/google-calendar/src/internal/uploads.ts(3 hunks)packages/google-calendar/src/internal/utils/base64.ts(1 hunks)packages/google-calendar/src/internal/utils/bytes.ts(1 hunks)packages/google-calendar/src/internal/utils/env.ts(1 hunks)packages/google-calendar/src/internal/utils/log.ts(1 hunks)packages/google-calendar/src/internal/utils/path.ts(1 hunks)packages/google-calendar/src/internal/utils/sleep.ts(1 hunks)packages/google-calendar/src/internal/utils/uuid.ts(1 hunks)packages/google-calendar/src/internal/utils/values.ts(1 hunks)packages/google-calendar/src/resources/calendars/acl.ts(1 hunks)packages/google-calendar/src/resources/calendars/calendars.ts(1 hunks)packages/google-calendar/src/resources/calendars/index.ts(1 hunks)packages/google-calendar/src/resources/check-free-busy.ts(1 hunks)packages/google-calendar/src/resources/index.ts(1 hunks)packages/google-calendar/src/resources/list-colors.ts(1 hunks)packages/google-calendar/src/resources/shared.ts(1 hunks)packages/google-calendar/src/resources/stop-watching.ts(1 hunks)packages/google-calendar/src/resources/users/me/calendar-list.ts(1 hunks)packages/google-calendar/src/resources/users/me/index.ts(1 hunks)packages/google-calendar/src/resources/users/me/me.ts(1 hunks)packages/google-calendar/src/resources/users/me/settings.ts(1 hunks)packages/google-calendar/src/resources/users/users.ts(1 hunks)packages/google-calendar/tsconfig.json(1 hunks)tooling/eslint-config/base.js(0 hunks)tooling/eslint-config/next.js(0 hunks)tooling/eslint-config/package.json(0 hunks)tooling/eslint-config/react.js(0 hunks)tooling/typescript-config/base.json(0 hunks)tooling/typescript-config/next.json(1 hunks)tooling/typescript-config/package.json(1 hunks)tooling/typescript-config/react.json(1 hunks)tsconfig.json(1 hunks)turbo.json(1 hunks)
💤 Files with no reviewable changes (11)
- tooling/typescript-config/base.json
- packages/db/eslint.config.mjs
- packages/api/eslint.config.mjs
- .prettierignore
- packages/auth/eslint.config.mjs
- tooling/eslint-config/react.js
- apps/web/eslint.config.mjs
- packages/env/eslint.config.mjs
- tooling/eslint-config/package.json
- tooling/eslint-config/next.js
- tooling/eslint-config/base.js
🧰 Additional context used
🧬 Code Graph Analysis (27)
packages/api/src/routers/user.ts (1)
packages/api/src/trpc.ts (1)
protectedProcedure(40-52)
packages/google-calendar/src/internal/utils/values.ts (2)
packages/google-calendar/src/index.ts (1)
GoogleCalendarError(9-9)packages/google-calendar/src/core/error.ts (1)
GoogleCalendarError(5-5)
packages/google-calendar/src/internal/qs/index.ts (1)
packages/google-calendar/src/internal/qs/formats.ts (1)
default_format(3-3)
apps/web/src/app/layout.tsx (2)
apps/web/src/app/(auth)/login/page.tsx (1)
metadata(7-9)apps/web/src/app/providers.tsx (1)
Providers(4-6)
packages/google-calendar/src/internal/request-options.ts (3)
packages/google-calendar/src/client.ts (2)
RequestOptions(746-746)request(309-314)packages/google-calendar/src/internal/types.ts (2)
HTTPMethod(4-4)MergedRequestInit(112-114)packages/google-calendar/src/internal/headers.ts (2)
HeadersLike(4-10)NullableHeaders(19-26)
apps/web/src/app/providers.tsx (1)
apps/web/src/lib/trpc/client.tsx (1)
TRPCReactProvider(28-63)
packages/google-calendar/src/core/api-promise.ts (3)
packages/google-calendar/src/client.ts (1)
GoogleCalendar(127-739)packages/google-calendar/src/internal/parse.ts (2)
APIResponseProps(7-14)defaultParseResponse(16-53)packages/google-calendar/src/internal/types.ts (1)
PromiseOrValue(3-3)
packages/api/src/root.ts (2)
packages/api/src/trpc.ts (1)
createTRPCRouter(36-36)packages/api/src/routers/user.ts (1)
userRouter(3-14)
packages/google-calendar/src/core/resource.ts (1)
packages/google-calendar/src/client.ts (1)
GoogleCalendar(127-739)
apps/web/src/app/page.tsx (2)
packages/db/src/schema/auth.ts (1)
session(15-26)packages/auth/src/server.ts (1)
auth(15-27)
packages/google-calendar/src/internal/detect-platform.ts (1)
packages/google-calendar/src/version.ts (1)
VERSION(1-1)
apps/web/src/components/ui/input.tsx (1)
apps/web/src/lib/utils.ts (1)
cn(4-6)
packages/google-calendar/src/core/error.ts (3)
packages/google-calendar/src/index.ts (13)
GoogleCalendarError(9-9)APIError(10-10)APIConnectionError(11-11)BadRequestError(17-17)AuthenticationError(18-18)PermissionDeniedError(20-20)NotFoundError(14-14)ConflictError(15-15)UnprocessableEntityError(21-21)RateLimitError(16-16)InternalServerError(19-19)APIUserAbortError(13-13)APIConnectionTimeoutError(12-12)packages/google-calendar/src/internal/errors.ts (1)
castToError(14-33)packages/google-calendar/src/resources/check-free-busy.ts (2)
Error(80-98)Error(117-135)
apps/web/src/components/ui/card.tsx (1)
apps/web/src/lib/utils.ts (1)
cn(4-6)
apps/web/src/components/ui/label.tsx (1)
apps/web/src/lib/utils.ts (1)
cn(4-6)
packages/google-calendar/src/internal/utils/base64.ts (2)
packages/google-calendar/src/internal/utils/bytes.ts (1)
encodeUTF8(17-24)packages/google-calendar/src/core/error.ts (1)
GoogleCalendarError(5-5)
packages/google-calendar/src/internal/utils/path.ts (2)
packages/google-calendar/src/index.ts (1)
GoogleCalendarError(9-9)packages/google-calendar/src/core/error.ts (1)
GoogleCalendarError(5-5)
apps/web/src/lib/trpc/query-client.tsx (1)
apps/web/src/lib/trpc/server.tsx (1)
getQueryClient(11-11)
apps/web/src/lib/trpc/server.tsx (2)
packages/api/src/root.ts (1)
appRouter(5-7)apps/web/src/lib/trpc/query-client.tsx (1)
getQueryClient(26-37)
packages/google-calendar/src/resources/users/me/settings.ts (5)
packages/google-calendar/src/core/resource.ts (1)
APIResource(5-11)packages/google-calendar/src/internal/request-options.ts (1)
RequestOptions(14-28)packages/google-calendar/src/core/api-promise.ts (1)
APIPromise(12-94)packages/google-calendar/src/internal/utils/path.ts (1)
path(67-67)packages/google-calendar/src/resources/shared.ts (1)
Channel(3-59)
packages/google-calendar/src/resources/stop-watching.ts (4)
packages/google-calendar/src/core/resource.ts (1)
APIResource(5-11)packages/google-calendar/src/internal/request-options.ts (1)
RequestOptions(14-28)packages/google-calendar/src/core/api-promise.ts (1)
APIPromise(12-94)packages/google-calendar/src/internal/headers.ts (1)
buildHeaders(71-96)
packages/google-calendar/src/internal/qs/stringify.ts (3)
packages/google-calendar/src/internal/qs/utils.ts (3)
encode(136-216)maybe_map(259-268)is_buffer(247-253)packages/google-calendar/src/internal/qs/formats.ts (2)
default_format(3-3)formatters(4-7)packages/google-calendar/src/internal/qs/types.ts (2)
NonNullableProperties(74-76)StringifyOptions(37-37)
apps/web/src/components/ui/button.tsx (1)
apps/web/src/lib/utils.ts (1)
cn(4-6)
packages/google-calendar/src/internal/qs/utils.ts (3)
packages/google-calendar/src/internal/qs/index.ts (2)
DefaultEncoder(15-15)Format(16-16)packages/google-calendar/src/internal/qs/types.ts (2)
DefaultEncoder(3-3)Format(1-1)packages/google-calendar/src/internal/qs/formats.ts (1)
RFC1738(8-8)
packages/google-calendar/src/resources/users/users.ts (2)
packages/google-calendar/src/resources/users/me/me.ts (1)
Me(26-29)packages/google-calendar/src/resources/users/index.ts (2)
Me(3-3)Users(4-4)
packages/google-calendar/src/internal/uploads.ts (3)
packages/google-calendar/src/internal/builtin-types.ts (2)
FilePropertyBag(91-93)Fetch(3-3)packages/google-calendar/src/internal/request-options.ts (1)
RequestOptions(14-28)packages/google-calendar/src/internal/shims.ts (1)
ReadableStreamFrom(38-58)
packages/google-calendar/src/internal/to-file.ts (2)
packages/google-calendar/src/internal/builtin-types.ts (1)
FilePropertyBag(91-93)packages/google-calendar/src/internal/uploads.ts (5)
checkFileSupport(16-30)makeFile(47-54)getName(56-70)BlobPart(6-6)isAsyncIterable(72-73)
🔇 Additional comments (213)
tsconfig.json (1)
1-2: Formatting-only change – trailing newline added
A newline was added at the end of the file to ensure consistent file endings across the repository. No functional changes introduced.tooling/typescript-config/package.json (1)
5-5: Formatting-only change – trailing newline added
Added a newline at the end of the file for consistency with other JSON configuration files. No content was altered.packages/db/tsconfig.json (1)
5-5: Formatting-only change – trailing newline added
A trailing newline was appended to maintain consistent file endings; no configuration changes were made.packages/api/tsconfig.json (1)
5-5: Formatting-only change – trailing newline added
Added a newline at end of file to align with editor and POSIX standards. No changes to configuration.packages/auth/tsconfig.json (1)
10-10: Formatting-only change – trailing newline added
The file now ends with a newline for consistent formatting across the repo. No functional changes were performed.packages/env/tsconfig.json (1)
5-5: Add final newline for consistent formatting.This newline ensures POSIX-style end-of-file compliance and aligns with the project’s
.editorconfigrules for JSON files.tooling/typescript-config/next.json (1)
16-16: Add final newline for consistent formatting.Aligns with the repository’s JSON formatting standards and EditorConfig settings, ensuring all config files end with a newline.
tooling/typescript-config/react.json (1)
7-7: Add final newline for consistent formatting.Ensures uniform file endings across all TypeScript config files per the new
.editorconfig.packages/google-calendar/tsconfig.json (1)
5-5: Add final newline for consistent formatting.Maintains consistency with other
tsconfig.jsonfiles and adheres to POSIX end-of-file conventions.apps/web/tsconfig.json (1)
16-16: Add final newline for consistent formatting.Completes the repository-wide formatting effort to standardize JSON file endings.
packages/api/src/routers/user.ts (1)
4-13: Consistent Tab-Based Indentation Applied
The indentation adjustments in themeprocedure align perfectly with the new.editorconfigrules, switching from spaces to tabs without altering any logic or functionality.apps/web/src/lib/utils.ts (1)
5-5: Formatting-Only Change: Tab Indentation
The single-line change in thecnfunction replaces two spaces with a tab, matching the project’s EditorConfig settings and preserving existing behavior.packages/env/src/server.ts (1)
5-15: Reformatted Environment Schema Block
All indentation within thecreateEnvcall has been normalized to tabs according to the new style guidelines; no schema logic or validations were modified.apps/web/src/components/icons/google.tsx (1)
2-33: Purely Stylistic Indentation Update
Tabs now uniformly indent both theGooglePropsinterface and the SVG JSX. No changes were made to prop definitions, SVG paths, or component behavior.packages/db/drizzle.config.ts (1)
4-9: Tab-Based Indentation in Drizzle Config
The object passed todefineConfighas been reindented using tabs only; configuration values remain unchanged.apps/web/src/app/page.tsx (3)
6-6: Formatting update aligns with project style guidelines.
Indentation converted to tabs per the new .editorconfig. No logic changes.
8-10: Formatting and syntax update approved.
Added trailing semicolon and aligned indentation to tabs as mandated by the shared EditorConfig. No behavioral change.
12-12: JSX simplified to a self-closing tag.
This is a purely stylistic change consistent with updated JSX conventions and the EditorConfig.packages/google-calendar/src/internal/builtin-types.ts (4)
3-3: No functional change; formatting only.
This export type declaration remains the same logically, now indented with tabs.
55-61: Export block re-indented.
All aliases are unchanged and merely reformatted to align with the tab-based indentation style.
80-81: Interface property indentation updated.
Propertiesendingsandtypeare identical in behavior; only whitespace changed.
92-92: Interface property re-indentation.
lastModifiedremains optional and unchanged in functionality.packages/google-calendar/src/internal/detect-platform.ts (1)
1-209: Formatting changes only.
The modifications throughout this file are limited to indentation and whitespace normalization (tabs versus spaces) per the new .editorconfig. No logic, type declarations, or control flow have been altered.apps/web/next.config.ts (1)
4-4: Comment indentation updated.
Converted two-space indent to a single tab to comply with the repository’s EditorConfig. No changes to config logic.packages/google-calendar/src/internal/qs/index.ts (2)
4-7: Object literal re-indented.
Theformatsconstant entries are unchanged semantically; formatting updated to tabs.
14-18: Type export block re-indented.
Type declarations are identical in content; only indentation has been standardized.packages/google-calendar/src/resources/shared.ts (1)
4-58: Formatting-only update: No functional changes.
Indentation has been converted from spaces to tabs in alignment with the new.editorconfigand Biome formatting rules. All interface properties, JSDoc comments, and types remain unchanged.packages/google-calendar/src/internal/qs/formats.ts (1)
5-6: Formatting-only update: Tab indentation applied.
The two formatter entries were re-indented from spaces to tabs. There is no change to their logic or signatures.packages/auth/src/server.ts (1)
8-13: Formatting-only update: Tab indentation applied.
Whitespace changes only—GOOGLE_OAUTH_SCOPESarray andauthconfiguration object have been re-indented to use tabs per the new style rules. No changes to values, order, or functionality.Also applies to: 16-26
packages/google-calendar/src/resources/calendars/index.ts (1)
4-13: Formatting-only update: Tab indentation applied.
Export blocks foracl,calendars, andeventswere re-indented with tabs. There are no modifications to the exported symbols or their ordering.Also applies to: 16-23, 24-36
packages/google-calendar/src/index.ts (1)
9-22: Formatting-only update: Tab indentation applied.
The error exports from./core/errorwere re-indented with tabs. No exports were added, removed, or reordered.packages/google-calendar/src/internal/utils/sleep.ts (1)
3-3: Formatting refinement applied correctlyThe
sleepfunction has been consolidated into a single concise line without altering its behavior. This aligns with the new Biome formatting rules.apps/web/src/app/globals.css (4)
7-37: Converted CSS indentation to tabs (stylistic change)The
:rootblock was re-indented from spaces to tabs only; there are no semantic changes. This matches the.editorconfigenforcement.
43-74: Converted CSS indentation to tabs (stylistic change)The
.darktheme definitions were re-indented with tabs; functionality remains the same.
78-115: Converted CSS indentation to tabs (stylistic change)The
@theme inlineproperties block was re-indented with tabs only; no value changes.
119-125: Converted CSS indentation to tabs (stylistic change)The
@layer baserules were re-indented with tabs; behavior is unchanged.packages/auth/package.json (1)
22-22: Removed outdated ESLint scripts and dependenciesThe closing brace shift indicates that the
scripts(includinglint) and ESLint-relateddevDependencieshave been dropped in favor of Biome. Ensure CI workflows and any local dev instructions referencebiome lintinstead ofnpm run lint.packages/env/src/client.ts (1)
4-6: Applied tab-based indentation (stylistic change)The properties passed to
createEnvwere re-indented with tabs; no API or logic changes.packages/db/package.json (1)
27-27: Removed ESLint devDependenciesThe removal of ESLint and the shared config in
devDependenciesaligns with the repository-wide transition to Biome. Verify there are no lingering ESLint references in CI or build scripts.packages/google-calendar/src/internal/utils/env.ts (1)
11-17: Consistent tab-based indentation applied
These changes normalize indentation to tabs in accordance with the newly introduced .editorconfig and Biome configuration. No functional behavior has been modified.apps/web/src/app/providers.tsx (1)
5-5: Tab indentation for JSX return
The indentation change aligns with the project-wide formatting standard (tabs via .editorconfig) and does not affect component behavior.apps/web/src/app/(auth)/login/page.tsx (1)
8-9: Apply uniform tab indentation throughout Page component
Stylistic formatting updates across metadata, session handling, and JSX return, consistent with the new tab-based indentation standard. No logic changes introduced.Also applies to: 12-16, 18-22
packages/google-calendar/src/core/resource.ts (1)
6-10: Normalize indentation in APIResource class
Whitespace changes adopt tabs per the updated .editorconfig; the class constructor and property assignment remain functionally identical.packages/api/src/root.ts (1)
2-2: Consolidated imports and consistent tab indentation
The import statement is now consolidated into a single line and indentation for theuserproperty uses tabs. These are purely stylistic refinements under the new formatting rules, with no impact on router functionality.Also applies to: 6-6
apps/web/src/app/api/trpc/[trpc]/route.ts (1)
7-18: Approve styling-only reformat
The re-indentation of thefetchRequestHandlercall using tabs is consistent with the newly introduced EditorConfig and Biome formatting rules. No logic or parameter changes detected.apps/web/package.json (1)
8-8: Approve addition ofstartscript
Including astartcommand (next start) complements the existingdevandbuildscripts, enabling a standard production startup flow.turbo.json (1)
37-38: Approve consistent JSON array formatting
Changing[ "DATABASE_URL" ]to["DATABASE_URL"]aligns with the project-wide whitespace rules enforced by EditorConfig/Biome. Functionality remains unchanged.Also applies to: 42-43, 48-49
packages/env/package.json (1)
18-18: Approve removal of ESLint scripts and deps
The deletion of the scripts section (includinglint) and ESLint-related devDependencies correctly reflects the migration to Biome-based linting.packages/google-calendar/src/resources/index.ts (4)
5-11: Approve re-indentation of Calendars export
Switching to tab-based indentation for theCalendarsexport block is purely stylistic, matching the new EditorConfig settings, with no changes to exported types or values.
14-16: Approve re-indentation of CheckFreeBusy export
This whitespace-only adjustment uses tabs per the repository’s formatting conventions. No impact on functionality.
19-21: Approve re-indentation of ListColors export
Aligned with global formatting changes; no modifications to the actual exports.
24-25: Approve re-indentation of StopWatching export
Formatting change only—tabs in place of spaces—to comply with EditorConfig.packages/google-calendar/src/resources/users/me/index.ts (2)
3-13: Formatting only: Standardized tab indentation in the first export blockThe export of
CalendarListand its associated types has been reformatted to use tabs for indentation, aligning with the new EditorConfig rules. No functionality was changed.
15-22: Formatting only: Standardized tab indentation in the second export blockThe export of
Settingsand related type declarations has been reindented with tabs, matching the updated project-wide style guidelines. No logical changes were made.apps/web/src/components/ui/input.tsx (2)
1-1: Use type-only import for ReactUpdated to a type-only import (
import type * as React from "react"), which removes unnecessary runtime imports when only types are required.
6-17: Formatting only: Consistent tab-based indentation in JSXThe JSX structure and its props have been reformatted to use tabs rather than spaces, in line with the new EditorConfig settings. No functional behavior has changed.
packages/google-calendar/src/internal/request-options.ts (4)
3-7: Convert imports to type-only importsThe imports of
NullableHeadersandHeadersLikehave been changed toimport type, clarifying their use for type annotations only and eliminating unneeded runtime code.
9-12: Formatting only: Tab-based indentation inFinalRequestOptionsThe
FinalRequestOptionstype alias has been reformatted with tabs for property alignment, adhering to the new style guide. No semantic modifications.
14-28: Formatting only: Tab-based indentation inRequestOptionsThe
RequestOptionsinterface has been updated to tab indentation and maintains its original properties and types.
30-43: Formatting only: Tab-based indentation for encoder definitionsUpdated
EncodedContent,RequestEncoder, andFallbackEncoderdeclarations to use tabs, ensuring consistent formatting. No behavior changes.packages/db/src/schema/auth.ts (4)
3-13: Formatting only: Convert indentation to tabs for theusertableThe
usertable schema now uses tabs for indentation instead of spaces, aligning with the repository’s EditorConfig rules. No structural changes.
15-26: Formatting only: Convert indentation to tabs for thesessiontableThe
sessiontable schema has been reformatted to use tabs for consistent indentation. All constraints and references remain the same.
28-44: Formatting only: Convert indentation to tabs for theaccounttableThe
accounttable schema indentation has been updated to tabs, matching the new style guidelines. No changes to column definitions.
46-53: Formatting only: Convert indentation to tabs for theverificationtableThe
verificationtable schema has been reformatted with tabs for indentation; functionality is unchanged.packages/google-calendar/src/resources/users/users.ts (1)
8-8: Tab-based indentation applied to class property and namespace export.
These are whitespace‐only updates aligning with the new EditorConfig/Biome formatting rules. No functional or API changes.Also applies to: 14-14
packages/google-calendar/src/internal/utils/values.ts (14)
9-10: Consistent tab indentation inisAbsoluteURL.
Adjusted indentation for the return statement to match the repository’s tab-based style; logic remains unchanged.
14-19: Tabbed indentation inmaybeObj.
Whitespace-only update formaybeObj, aligning braces and return statements with the new formatting configuration. No behavioral impact.
23-25: Tabbed formatting inisEmptyObj.
Formatting-only change; the function’s semantics are intact.
29-30: Tab-based indent forhasOwn.
Normalized indentation; function logic is unchanged.
33-34: Tabbed formatting inisObj.
Indentation aligned with EditorConfig; no functional changes.
37-42: Normalized tabs inensurePresent.
Indentation standardized; error handling and return semantics remain the same.
45-52: Tabbed indentation invalidatePositiveInteger.
Whitespace normalization; validation logic and error messages are unchanged.
55-59: Tab formatting incoerceInteger.
Formatting update only; coercion logic is intact.
62-66: Tab-based indent forcoerceFloat.
Whitespace-only adjustment; behavior remains consistent.
69-72: Tabbed formatting incoerceBoolean.
Indentation normalized; no logic modifications.
75-79: Tab indentation inmaybeCoerceInteger.
Whitespace normalization; semantics unchanged.
82-86: Tab formatting inmaybeCoerceFloat.
Formatting-only update; behavior intact.
89-93: Tabbed indentation inmaybeCoerceBoolean.
Indentation aligned with new style rules; no functional changes.
97-101: Tab-based formatting insafeJSON.
Whitespace-only update; error handling behavior is preserved.packages/google-calendar/src/internal/utils/bytes.ts (3)
2-13: Tab indentation inconcatBytes.
Formatting migration to tabs; the byte concatenation algorithm and its performance characteristics are unchanged.
19-24: Tab-based formatting inencodeUTF8.
Reformatted indentation while preserving the TextEncoder caching logic.
28-33: Tabbed formatting indecodeUTF8.
Whitespace-only adjustment; decoding logic remains intact.apps/web/src/app/layout.tsx (4)
8-10: Applied tab-based indentation toGeistfont config.
Converted spaces to tabs for thegeistSansvariable setup. No changes to functionality.
13-15: Tab indentation forGeist_Monofont config.
Whitespace-only update consistent with EditorConfig rules; font configuration unchanged.
18-19: Tabbed formatting inmetadataexport.
Adjusted indentation for thetitleproperty; semantics are unchanged.
21-28: FormattedRootLayoutcomponent with tabs.
Reformatted JSX indentation to use tabs consistently; component structure and behavior are unchanged.packages/google-calendar/src/core/uploads.ts (1)
1-1: Switched to pureexport typesyntax forUploadable.
Changed to a type-only export to ensure clarity and prevent runtime import side effects, aligning with project-wide type import/export conventions.apps/web/src/lib/trpc/client.tsx (9)
5-5: Approve consolidated TRPC imports: Consolidated imports on a single line to comply with the new Biome/linting style guide.
15-18: Indentation adjustment in getUrl function: Applied tab-based indentation per.editorconfigfor consistency.
21-21: URL template literal formatting: Ensures consistent spacing and indentation in the return statement.
25-25: Prop interface formatting: Aligned thechildrenproperty indentation within the interface.
29-32: Comment block indentation: Multi-line comment re-indented for readability and alignment with style rules.
34-35: State hook initialization alignment: Adjusted indentation for theuseStateinitializer arrow function.
37-41: LoggerLink indentation: Reformatted nested callback inloggerLinkfor consistent tab usage.
43-50: httpBatchStreamLink formatting: Wrapped link configuration in consistent indentation blocks.
56-62: JSX return styling: Formatted JSX tree withinTRPCReactProviderto follow indentation guidelines..editorconfig (4)
1-1: Enable root directory flag:root = truecorrectly marks this as the project root for EditorConfig.
3-10: Default formatting rules: Charset, EOL, indent style, line length, and whitespace trimming defined as intended.
11-13: JSON override:indent_style = spacefor JSON files aligns with project requirements.
14-16: YAML override: Indentation style set to space for YAML/YML files as specified.packages/google-calendar/src/core/error.ts (11)
8-10: Generic type parameter formatting: Multiline formatting of theAPIErrorgeneric parameters improves readability under the new styling rules.
12-17: Class member indentation: Aligned JSDoc comments andreadonlyproperties according to.editorconfig.
19-24: Constructor styling: Consistent indentation and spacing applied to the constructor signature and body.
26-34: makeMessage method alignment: Adjusted nested ternary and error-serialization logic indentation for clarity.
35-43: Conditional blocks in makeMessage: Reformattedifbranches to maintain consistent tab-based structure.
44-45: makeMessage fallback alignment: Final return and block closure aligned with style guidelines.
47-95: Static generate method formatting: Bulk update of indentation in thegeneratemethod to conform with project-wide style.
98-102: APIUserAbortError formatting: Subclass declaration and constructor indentation normalized.
104-116: APIConnectionError formatting: Destructured constructor parameters and ts-ignore handling aligned with style.
119-123: APIConnectionTimeoutError styling: Constructor parameter default and call formatting updated.
125-139: Error subclasses formatting: Single-line subclass declarations (e.g.,BadRequestError) consistently indented.packages/google-calendar/src/internal/parse.ts (10)
4-4: Type-only import formatting: Standardizedimport typeindentation to align with style rules.
8-13: APIResponseProps type formatting: Aligned properties in the interface per.editorconfig.
16-19: Function signature alignment: AdjusteddefaultParseResponsesignature indentation for readability.
20-21: Destructuring indentation: Reformatted object destructuring assignment under the same indentation scope.
23-25: 204 status branch styling: Consistent indentation for early return on HTTP 204.
27-29: Binary response branch formatting: Indented binary response check and return consistently.
31-37: JSON parsing block: ReformattedisJSONcondition and parsing logic to follow style guide.
39-41: Text fallback formatting: Ensured fallback path is indented correctly.
42-51: Logging statement alignment: FormattedloggerForcall and argument object across multiple lines.
52-52: Return indentation: Finalreturn body;aligned with function scope indent.packages/google-calendar/src/internal/utils/path.ts (9)
12-12: encodeURIPath formatting: Single-linereplacecall indented per style settings.
16-19: createPathTagFunction signature: Reformatted function factory signature and initial comment.
21-33: Path assembly logic: Alignedreducecallback and template concatenation insidecreatePathTagFunction.
35-39: Invalid segments detection setup: Reformatted variable declarations and regex initialization.
41-47: While loop formatting: Adjustedwhileloop body and segment push logic indentation.
50-57: Error message construction: Alignedreducelogic for building the underline and error throw message.
60-63: Throw block styling:throw new GoogleCalendarErrorand message formatting adjusted.
65-66: Return closure indent: Alignedreturn path;with closure’s indentation.
68-68: Named export formatting: Export ofpathconstant indented as per style.apps/web/src/app/(auth)/login/sign-in-form.tsx (7)
8-14: Formatting: Aligned Card imports
The indentation of the multi-line import forCardand its subcomponents has been updated to tabs, matching the new.editorconfigrules. No changes to functionality.
19-20: Formatting: SignInFormProps interface alignment
The optionalredirectUrlprop is now indented with a tab and defaults to"/", consistent with project style. No logic change.
23-24: Formatting: useState hook alignment
TheuseStatedeclaration is now indented using tabs and aligns with the component structure. Behavior remains unchanged.
25-40: Formatting: signInWithGoogle function indentation
The async function body and its callback handlers have been reformatted for consistent tab-based indentation. Logic for settingloadingremains intact.
42-49: Formatting: JSX Card and header layout
The JSX for<Card>and its header elements has been compacted and re-indented to adhere to the new style guidelines. No functional modifications.
50-62: Formatting: CardContent and Button block
The nested<Button>markup andclassNameusages have been realigned with tabs. Thecnutility usage is unaffected.
65-76: Formatting: CardFooter and link markup
Links to Terms and Privacy are now indented consistently. The JSX structure and behavior remain exactly the same.packages/google-calendar/src/internal/headers.ts (5)
5-10: Formatting: ExpandedHeadersLikeunion alignment
The union members forHeadersLikehave been realigned to use tab indentation, without altering the type definitions.
19-26: Formatting:NullableHeaderstype block
The multi-lineNullableHeadersdeclaration, including branded property and comments, has been indented and spaced per.editorconfig. No semantic changes.
30-40: Formatting:iterateHeadersgenerator function
Indentation and spacing in theiterateHeadersfunction have been adjusted; the control flow and iteration semantics are unchanged.
71-96: Formatting:buildHeadersimplementation
The entirebuildHeadersfunction has been reformatted with tabs and consistent line breaks. Its logic for merging and nulling headers is intact.
98-102: Formatting:isEmptyHeadershelper
The utility function for checking empty headers has been realigned for tab indentation. Behavior remains the same.apps/web/src/components/ui/label.tsx (3)
3-3: Formatting: Type-only React import
Changed the React import to a type-only import and aligned it with tabs. No effect on runtime.
8-11: Formatting:Labelcomponent declaration
The function signature and return statement have been reformatted for consistent indentation. No API or behavior updates.
12-17: Formatting:classNamecomposition
Thecncall and its arguments have been realigned with tabs; styling and class merging remain unchanged.apps/web/src/lib/trpc/server.tsx (4)
4-4: Formatting: Consolidated trpc import
The import forcreateTRPCOptionsProxyand the typeTRPCQueryOptionshas been adjusted to use tabs. No semantic effect.
15-19: Formatting:createTRPCOptionsProxyconfiguration
The proxy setup object (ctx,router,queryClient) has been realigned for tab-based indentation. Logic remains identical.
23-27: Formatting:HydrateClientcomponent
ThegetQueryClientcall and<HydrationBoundary>JSX have been reformatted. Behavior is unchanged.
29-36: Formatting:prefetchhelper function
The genericprefetchfunction and its conditional branches for infinite vs. standard queries have been indented with tabs. No logic changes.packages/google-calendar/src/internal/utils/base64.ts (2)
6-24: Formatting:toBase64function block
The signature, branches (Buffer, string encoding, btoa), and error throw have been reformatted using tab indentation and consistent spacing. Logic is unchanged.
26-44: Formatting:fromBase64function block
The signature, Buffer decoding, atob fallback, and error handling have been realigned to tabs. No changes to behavior or outputs.packages/google-calendar/src/resources/list-colors.ts (6)
4-5: Good conversion to type-only imports.You've properly converted the imports of
APIPromiseandRequestOptionsto type-only imports using theimport typesyntax, which is a good practice as these are only used for type checking and not at runtime.
8-16: Indentation consistency looks good.The JSDoc comments and method implementation have been properly reformatted using tab indentation according to the new code style standards.
19-43: Proper interface formatting.The interface and its JSDoc comments have been consistently formatted with tabs, maintaining good readability while conforming to the new code style.
45-77: Nested interfaces are properly formatted.The nested interfaces within the namespace have been consistently reformatted while maintaining the semantic structure.
79-116: Parameter interface properly reformatted.The parameter interface and its JSDoc comments have been consistently reformatted with tabs without changing the content or structure.
118-120: Good export simplification.You've simplified the export namespace by using the more concise
export type { ... }syntax.packages/google-calendar/src/internal/shim-types.d.ts (3)
16-16: Good conversion from interface to type alias.Changed from an empty interface to an empty type alias, which is more appropriate for this use case.
23-24: Improved conditional type formatting.The conditional type declaration has been reformatted to a single line, making it more concise while maintaining readability.
27-29: Consistent ternary formatting.The conditional declaration has been reformatted to use a consistent style with the rest of the codebase.
packages/google-calendar/src/internal/utils/uuid.ts (1)
6-19: Good function style modernization.The function has been converted from a traditional function expression to an arrow function expression without changing its behavior or memoization pattern.
packages/google-calendar/src/resources/calendars/acl.ts (5)
4-7: Good conversion to type-only imports.You've properly converted the imports to use the
import typesyntax where appropriate, which is a good practice for types that aren't needed at runtime.
11-163: Methods properly reformatted.All the class methods have been consistently reformatted with tab indentation while preserving their functionality.
165-633: Interfaces properly reformatted.The interfaces, nested interfaces, and namespaces have been consistently reformatted with tabs without changing their structure or type definitions.
635-760: Parameter interfaces properly formatted.The parameter interfaces have been consistently reformatted with tabs, maintaining good readability while aligning with the new code style standards.
762-773: Export namespace properly formatted.The export namespace has been reformatted to use the more conventional export syntax.
apps/web/src/components/ui/card.tsx (3)
1-1: Use type-only import for React
Switching the React import to a type-only import is consistent with TypeScript’simport typesemantics and avoids bundling the React namespace at runtime.
6-15: Formatting-only changes (tab-based indentation and JSX reformatting) are consistent across the codebase and introduce no functional changes.Also applies to: 19-27, 31-37, 41-49, 53-59, 61-63
75-75: Consolidated export statement
Grouping all Card component exports into a single statement reduces verbosity and improves readability.packages/google-calendar/src/core/api-promise.ts (2)
3-7: Consistent type-only imports
Separating purely type-based imports (GoogleCalendar,PromiseOrValue,APIResponseProps) from runtime imports maintains clarity and aligns with the project’s import conventions.
13-32: The rest of the changes are tab-based indentation and whitespace adjustments without altering any logic.Also applies to: 39-94
packages/google-calendar/src/internal/shims.ts (2)
10-11: Use type-only imports
SwitchingFetchandReadableStreamto type-only imports ensures no unintended runtime dependencies and aligns with the standardized import style.
25-36: All other edits are formatting and indentation changes only; there are no functional modifications.Also applies to: 38-58, 66-110
packages/api/src/trpc.ts (1)
9-12: This file only received tab-based indentation and whitespace normalization; its logic and API surface remain unchanged.Also applies to: 22-31, 40-52
apps/web/src/components/ui/button.tsx (4)
1-1: Use type-only import for React
Conversion toimport type * as React from "react";cleanly separates types from runtime code. No impact on functionality.
7-33: ReformatbuttonVariantsdefinition for consistent indentation
Thecvainvocation has been reformatted (tabs, spacing) to comply with the new EditorConfig style. No changes to the variant definitions themselves.
35-44: NormalizeButtoncomponent signature formatting
Props destructuring and type annotations have been realigned using tab-based indentation for readability. The signature and behavior remain the same.
47-53: Format JSXreturnblock with tab indentation
The JSX return has been adjusted to match the tab-based style without altering any attributes or component logic.apps/web/src/lib/trpc/query-client.tsx (3)
1-4: Consolidate and reformat import statements
Imports from@tanstack/react-queryandsuperjsonhave been merged and aligned with tab indentation. These are stylistic changes only.
5-22: ReformatmakeQueryClientwith consistent indentation
ThemakeQueryClientfunction’s options and nested objects are now tab-indented uniformly. No adjustments to the defaultOptions or serialization logic.
27-36: SimplifygetQueryClientcontrol flow formatting
Removed an unnecessaryelseand realigned the server/browser branches with tabs. The logic for reusing or recreating the client is unchanged.packages/google-calendar/src/resources/check-free-busy.ts (3)
4-6: Convert imports to type-only for dependencies
TheAPIPromiseandRequestOptionsimports are nowimport type, enforcing compile-time usage only.
7-21: ReformatcheckFreeBusymethod for consistent indentation
JSDoc, method signature, parameter destructuring, and the_client.postcall have been realigned using tabs. No change to request path or payload structure.
24-223: Reformat type and namespace declarations
All interface (CheckFreeBusyCheckFreeBusyResponse, nestedCalendars/Groups,CheckFreeBusyCheckFreeBusyParams,Item) and theexport declare namespace CheckFreeBusyblock have been tab-indented and spaced for uniformity. Type shapes remain identical.packages/google-calendar/src/resources/users/me/me.ts (4)
5-15: Reformat imports fromcalendar-listwith consistent tabs
The multi-line import of calendar-list entities has been aligned with tab indentation. All imported names are preserved.
17-24: Reformat imports fromsettingswith consistent tabs
The settings imports have been similarly realigned. No API surface modifications.
27-28: Normalize class property initializations inMe
ThecalendarListandsettingsmembers are now tab-indented to match EditorConfig conventions. Behavior is unchanged.
35-55: Reformat exported namespaceMedeclarations
The re-export block underexport declare namespace Mehas been reformatted for clarity and consistent indentation. All exports remain the same.packages/google-calendar/src/internal/types.ts (6)
15-35: ReformatOverloadedParameterstype declaration
The conditional type branches for up to four overloads have been realigned using tabs. No change to the inference logic.
60-70: NormalizeUndiciTypesRequestInitunion declaration
All imported paths and union members have been tab-indented for readability. Type resolution remains the same.
73-82: NormalizeUndiciRequestInitunion declaration
This union’s formatting has been similarly updated; no modifications to the types themselves.
87-96: NormalizeNodeFetchRequestInitunion declaration
Consistent indentation applied across the union cases. Import paths and semantics are unchanged.
101-106: ReformatRequestInitsunion type
Union members are now tab-aligned. All variants remain available in the same order.
113-114: FormatMergedRequestInittype intersection
The intersection withPartial<Record<...>>has been indented for clarity. No alteration to the resulting type.packages/google-calendar/src/resources/users/me/settings.ts (1)
4-6: Converted runtime imports to type-only imports
Usingimport typeforShared,APIPromise, andRequestOptionsremoves unnecessary runtime code and clarifies that these imports are solely for type annotations.packages/google-calendar/src/internal/qs/utils.ts (1)
7-268: Formatting-only updates
All changes in this file are indentation normalization to tabs and minor stylistic adjustments (spacing, arrow function usage, etc.). There are no logic or API signature modifications.packages/google-calendar/src/internal/utils/log.ts (1)
3-6: Type-only imports and non-destructive property clearing
- Great use of
import typeforGoogleCalendarandRequestOptionsto eliminate runtime overhead.- Replacing
deletewith= undefinedmaintains the object’s property shape (beneficial for TypeScript typing and JSON serialization) without reintroducing sensitive header values. Behavior remains consistent.Also applies to: 100-102, 117-122
packages/google-calendar/src/resources/stop-watching.ts (1)
3-6: Converted runtime imports to type-only imports
Switching toimport typeforAPIPromiseandRequestOptionsreduces bundle size and makes clear that these imports are only used at compile time.packages/google-calendar/src/internal/qs/types.ts (1)
3-76: Well-formatted type definitions!The indentation changes align with the project's shift to use tabs instead of spaces, as defined in the new EditorConfig settings. The type definitions remain functionally identical with proper formatting.
packages/google-calendar/src/internal/to-file.ts (2)
1-1: Good use of type-only import!Adding
typeto the import statement clarifies thatBlobPartis only used as a type, which can help with tree-shaking during build.
5-156: Properly formatted code with consistent indentationThe code has been reformatted to use tabs consistently throughout the file while maintaining all functionality. The interfaces, type guards, and utility functions remain semantically identical.
packages/google-calendar/src/internal/uploads.ts (3)
1-1: Good use of type-only import!Converting the import to a type-only import clarifies that
RequestOptionsis only used as a type, which can help with tree-shaking during build.
16-29: Good conversion to template literalsReplacing string concatenation with template literals improves readability while maintaining functionality.
47-197: Properly formatted code with consistent indentationThe code has been reformatted to use tabs consistently throughout the file while maintaining all functionality. The utility functions for handling file uploads and form data remain semantically identical.
packages/google-calendar/src/internal/errors.ts (2)
3-11: Type refinement inisAbortError
The function signature has been updated to acceptunknowninstead ofany, improving type safety without altering behavior. The runtime checks remain correct, guarding against non-object or null values.
14-33: Enhanced error normalization incastToError
Changing the parameter tounknownand preserving the normalization logic (including legacy@ts-ignoreforcause) is a solid type‐safety improvement. No logic was modified.biome.jsonc (1)
1-67: New Biome configuration for linting & formatting
Thebiome.jsoncfile correctly replaces ESLint/Prettier settings, enabling the formatter and linter with sensible overrides and integrating with EditorConfig. The rule set aligns with project conventions and there are no conflicting or redundant settings.packages/google-calendar/src/resources/calendars/calendars.ts (1)
6-15: Stylistic adjustments and type-only imports
Formatting changes (tabs, alignment) and the introduction ofimport typefor purely type imports are consistent and preserve all public API signatures. The class properties and import blocks have been updated without affecting functionality.Also applies to: 19-30, 32-34, 37-38
packages/google-calendar/src/internal/qs/stringify.ts (1)
8-17: Formatting standardization of query-string utilities
All modifications are indentation and style normalizations (tabs, arrow functions) with no changes to logic or behavior. Core routines (inner_stringify,normalize_stringify_options,stringify) remain functionally identical.Also applies to: 22-24, 29-49, 51-58, 63-218, 225-319, 322-401
packages/google-calendar/src/client.ts (1)
3-9: Global stylistic update and import refinements
The changes across imports (introducingimport typefor type-only dependencies), class constructor adjustments, method signatures, and internal helpers are purely formatting-related. No functional logic or public interface has been altered.Also applies to: 11-11, 13-13, 26-28, 30-32, 35-37, 39-39, 44-50, 155-158, 171-178, 183-184, 186-186, 188-188, 194-195, 208-210, 216-218, 220-222, 228-230, 232-239
packages/google-calendar/src/resources/users/me/calendar-list.ts (3)
4-7: Imports converted to type-only
SwitchingShared,APIPromise, andRequestOptionsimports toimport typeensures no runtime code is generated for these type-only dependencies.
1-3: Reformatting to tabs applied
The file has been reformatted to use tabs for indentation across imports, JSDoc, and method signatures, aligning with the project's Biome lint/format rules. No functional changes detected.Also applies to: 8-16
1173-1182: Simplified namespace re-exports
Directly re-exporting types withtypemodifiers removes redundant aliases and keeps runtime bundles clean.
|
@AugustinMauroy I would need it to match the prettier (default) config, so e.g. indent. Furthermore, what the lint config, e.g. will it still warn if an env variable is missing from turbo.json? |
I'll take a look but for JSON and yaml we cannot touch.
normally no nedded we are on root |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/next.config.ts (1)
4-6: Configuration updated to ignore ESLint during builds.This change disables ESLint checks during Next.js builds, which is consistent with the project's transition from ESLint to Biome for linting and formatting as mentioned in the PR summary.
Consider adding a brief comment explaining why ESLint is being disabled during builds:
const nextConfig: NextConfig = { + // Disable ESLint during builds as we're using Biome for linting instead eslint: { ignoreDuringBuilds: true, }, };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (29)
.editorconfig(1 hunks)apps/web/components.json(1 hunks)apps/web/next.config.ts(1 hunks)apps/web/package.json(1 hunks)apps/web/src/components/ui/card.tsx(1 hunks)apps/web/src/lib/trpc/client.tsx(2 hunks)apps/web/tsconfig.json(1 hunks)package.json(1 hunks)packages/api/package.json(1 hunks)packages/api/tsconfig.json(1 hunks)packages/auth/package.json(1 hunks)packages/auth/tsconfig.json(1 hunks)packages/db/package.json(1 hunks)packages/db/tsconfig.json(1 hunks)packages/env/package.json(1 hunks)packages/env/tsconfig.json(1 hunks)packages/google-calendar/package.json(1 hunks)packages/google-calendar/src/client.ts(2 hunks)packages/google-calendar/src/core/api-promise.ts(1 hunks)packages/google-calendar/src/internal/qs/stringify.ts(1 hunks)packages/google-calendar/src/internal/shims.ts(2 hunks)packages/google-calendar/src/internal/utils/bytes.ts(1 hunks)packages/google-calendar/src/resources/users/me/calendar-list.ts(1 hunks)packages/google-calendar/tsconfig.json(1 hunks)tooling/typescript-config/base.json(1 hunks)tooling/typescript-config/next.json(1 hunks)tooling/typescript-config/package.json(1 hunks)tooling/typescript-config/react.json(1 hunks)turbo.json(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- apps/web/components.json
- packages/google-calendar/package.json
- packages/google-calendar/src/core/api-promise.ts
- apps/web/src/lib/trpc/client.tsx
- packages/google-calendar/src/internal/qs/stringify.ts
🚧 Files skipped from review as they are similar to previous changes (23)
- packages/api/tsconfig.json
- packages/env/tsconfig.json
- packages/db/tsconfig.json
- packages/auth/tsconfig.json
- tooling/typescript-config/package.json
- apps/web/tsconfig.json
- tooling/typescript-config/base.json
- packages/db/package.json
- tooling/typescript-config/react.json
- packages/env/package.json
- packages/auth/package.json
- packages/google-calendar/tsconfig.json
- tooling/typescript-config/next.json
- turbo.json
- packages/google-calendar/src/internal/utils/bytes.ts
- apps/web/package.json
- packages/api/package.json
- apps/web/src/components/ui/card.tsx
- packages/google-calendar/src/internal/shims.ts
- .editorconfig
- package.json
- packages/google-calendar/src/resources/users/me/calendar-list.ts
- packages/google-calendar/src/client.ts
|
I'm not sure I see the benefit in this switch. ESLint is configured correctly throughout the repo with relevant rules for this stack. |
close #5
Summary by CodeRabbit
Chores
Style
Bug Fixes
Documentation