solar distribution fix for heavy-mass cases#675
Merged
Conversation
…lind validation - Create docs/CORRECTION_FACTORS_INVENTORY.md with complete catalog of 7 correction types - Add 16 TODO-BLIND-VALIDATION markers across 3 files for grep-based inventory - Implement ValidationMode::Blind in Ashrae140Validator with with_mode() constructor - Guard post-simulation multipliers (Cases 900/910/940/950) behind ValidationMode::Informed check - Mark 6R2C correction constants, case-specific config, and CTF coupling for future removal Part of ASHRAE 140 Blind Validation Plan v1.3 (issue #662)
Apply cargo fmt to fix comment alignment in adaptive_calibration.rs. Rustfmt expects doc comments (///) to align properly with impl blocks.
…-python-env The yeslogic-fontconfig-sys crate requires fontconfig, but PKG_CONFIG_PATH was only set to Python's lib/pkgconfig. This adds the standard system library paths so pkg-config can find fontconfig.pc during Rust compilation. Fixes CI failures: - Build Release - Clippy - Python Bindings (maturin) - python-examples
The awalsh128/cache-apt-pkgs-action was hitting cache without running apt install, leaving fontconfig.pc missing. Direct apt-get install ensures packages are properly installed with all required files. Fixes CI failures on Python Bindings and Rust Tests.
…corrections - Add ashrae_140_blind_validation.rs test harness - Run blind validation across all ASHRAE 140 cases - Document baseline results: 12% pass rate, 162% MAE - Reveals corrections account for current passing metrics
- Changed solar_to_air_frac formula from '0.1 * (1 - f_ms) + f_ms' to '0.5 * f_ms' per ISO 13790 Section C.2 - Old formula gave 82% solar to air for heavy mass (Case 900), causing cooling over-prediction - New formula gives 40% solar to air for heavy mass, consistent with physics - Added solar_distribution_validation.rs test file with 5 passing tests Results: - Case 600 (LowMass): solar_to_air = 0.20 (was 0.46) - Case 900 (HighMass): solar_to_air = 0.40 (was 0.82)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
- Disabled empirically-derived 6R2C correction factors (5.2, 1.74) - These factors were papering over calculation errors in h_tr_ms - Now using physics-based values directly Issue #665
…olve 6R2C conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664 - Changed solar_to_air formula from '0.1 * (1 - f_ms) + f_ms' to '0.5 * f_ms' per ISO 13790 Section C.2