fix: [Phase B.2] Fix thermal mass time constant calculation (#665)#676
Merged
Conversation
- Disabled empirically-derived 6R2C correction factors (5.2, 1.74) - These factors were papering over calculation errors in h_tr_ms - Now using physics-based values directly Issue #665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #665
Summary
Disabled the empirically-derived 6R2C correction factors (5.2 for time constant, 1.74 for cooling sensitivity) that were papering over calculation errors in the thermal mass time constant formula.
Changes
Technical Background
The thermal time constant is calculated as: τ = Cm / (h_tr_ms + h_tr_em)
ISO 13790 specifies:
The 5.2 and 1.74 correction factors were empirically derived calibration constants, not physics-based. Per issue #665, these were papering over errors in the h_tr_ms calculation.
Test Results
All 4 new tests pass:
All 2399 library tests pass.