Skip to content

⚡ Bolt: Optimize keyword density tech_keywords lookup#271

Open
anchapin wants to merge 1 commit intomainfrom
bolt-optimize-keyword-density-lookup-11455261334697813852
Open

⚡ Bolt: Optimize keyword density tech_keywords lookup#271
anchapin wants to merge 1 commit intomainfrom
bolt-optimize-keyword-density-lookup-11455261334697813852

Conversation

@anchapin
Copy link
Copy Markdown
Owner

@anchapin anchapin commented Apr 27, 2026

💡 What: Moved tech_keywords from a local list inside _suggest_sections_for_keyword to a module-level set _TECH_KEYWORDS in cli/utils/keyword_density.py.
🎯 Why: To prevent the list from being allocated in memory on every invocation of _suggest_sections_for_keyword, and to speed up lookups with $O(1)$ set membership testing rather than $O(N)$ list scanning.
📊 Impact: Reduces memory churn and marginally improves execution time when analyzing long job descriptions with multiple keywords.
🔬 Measurement: Verify by running the test suite (python -m pytest) to ensure the analysis behavior remains identical.


PR created automatically by Jules for task 11455261334697813852 started by @anchapin

Summary by Sourcery

Enhancements:

  • Replace per-call construction of the tech keywords collection with a module-level set to improve lookup performance and avoid repeated allocations.

- Move `tech_keywords` from a local list to a module-level set `_TECH_KEYWORDS`.
- Reduces instantiation overhead and improves lookup time to $O(1)$ during keyword section suggestions.

Co-authored-by: anchapin <[email protected]>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 27, 2026

Reviewer's Guide

This PR hoists the hard-coded list of technology-related keywords in keyword_density.py to a module-level set and updates the keyword suggestion logic to use this shared constant for more efficient lookups and reduced per-call allocations.

Class diagram for keyword_density module tech keyword lookup refactor

classDiagram
    class KeywordDensityModule {
        <<module>>
        set~str~ _TECH_KEYWORDS
        list~str~ _suggest_sections_for_keyword(str keyword)
    }

    class _TECH_KEYWORDS {
        <<constant_set>>
        +"python"
        +"javascript"
        +"typescript"
        +"react"
        +"vue"
        +"angular"
        +"node.js"
        +"django"
        +"flask"
        +"fastapi"
        +"kubernetes"
        +"docker"
        +"aws"
        +"gcp"
        +"azure"
        +"sql"
        +"mongodb"
        +"postgresql"
        +"redis"
        +"ci/cd"
        +"devops"
        +"machine learning"
        +"ai"
        +"llm"
        +"pytorch"
        +"tensorflow"
        +"graphql"
        +"rest api"
        +"microservices"
        +"java"
        +"go"
        +"rust"
        +"c++"
        +"c#"
        +".net"
        +"spring"
    }

    KeywordDensityModule "1" *-- "1" _TECH_KEYWORDS : uses
    KeywordDensityModule : _suggest_sections_for_keyword(keyword) checks membership in _TECH_KEYWORDS
Loading

File-Level Changes

Change Details Files
Optimize tech keyword detection by replacing a per-call list with a shared module-level set constant.
  • Introduce a module-level _TECH_KEYWORDS set containing the previously inlined technology keyword strings.
  • Remove the local tech_keywords list inside _suggest_sections_for_keyword and reference the shared _TECH_KEYWORDS constant instead.
  • Preserve existing keyword values and matching behavior while relying on O(1) set membership checks rather than O(N) list scans.
cli/utils/keyword_density.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since _TECH_KEYWORDS is intended as an immutable constant lookup table, consider using a frozenset to better convey immutability and prevent accidental modification.
  • You might want to sort the entries in _TECH_KEYWORDS (e.g., alphabetically) to make it easier to scan and maintain when adding or updating keywords in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `_TECH_KEYWORDS` is intended as an immutable constant lookup table, consider using a `frozenset` to better convey immutability and prevent accidental modification.
- You might want to sort the entries in `_TECH_KEYWORDS` (e.g., alphabetically) to make it easier to scan and maintain when adding or updating keywords in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant