🛡️ Sentinel: [CRITICAL] Fix command injection vulnerability in CoverLetterGenerator

[anchapin]

🚨 Severity: CRITICAL
💡 Vulnerability: The CoverLetterGenerator executed pdflatex (and the pandoc fallback) without the -no-shell-escape flag. This creates a critical Remote Code Execution (RCE) vulnerability if a user or the AI generates malicious LaTeX code (such as \write18). Additionally, the subprocess calls lacked a timeout, leading to potential Denial of Service (DoS) via infinite compilation loops.
🎯 Impact: An attacker could execute arbitrary system commands via maliciously crafted LaTeX inputs, or freeze the application by inducing infinite PDF compilation processes.
🔧 Fix: Added the -no-shell-escape flag to the pdflatex call and --pdf-engine-opt=-no-shell-escape to the pandoc call. Implemented a strict 30-second timeout using process.communicate(timeout=30), with explicit cleanup logic (catching subprocess.TimeoutExpired, calling process.kill(), and calling .communicate() again to prevent zombie processes).
✅ Verification: Ran pytest tests/test_cover_letter_generator.py and confirmed the new timeout and mock parameter checks pass successfully.

---

PR created automatically by Jules for task 12501750482418027070 started by @anchapin

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery