⚡ Bolt: Optimize keyword density parsing by hoisting constants#280
⚡ Bolt: Optimize keyword density parsing by hoisting constants#280
Conversation
- Moved title and company regex patterns to module-level constants `_TITLE_PATTERNS` and `_COMPANY_PATTERNS` to avoid repeated re-compilation. - Extracted static fallback tech keywords into a module-level set (`_TECH_KEYWORDS`) to optimize membership checking to O(1) time complexity and eliminate redundant allocations. - Moved `common_keywords` from inside `_simple_keyword_extraction` to a module-level constant list `_COMMON_KEYWORDS`. Co-authored-by: anchapin <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1 participant
💡 What: Hoisted static variables (regex patterns, common fallback keywords, and tech keywords) in
cli/utils/keyword_density.pyto module-level constants. Converted the tech keywords list to a set.🎯 Why: To reduce the CPU overhead caused by repeated compilation of regular expressions and to eliminate the memory overhead associated with dynamically re-allocating static lists inside frequently called functions during the keyword density analysis. Using a set for the tech keywords drops lookup complexity from O(n) to O(1).
📊 Impact: Lowers memory pressure and execution time for the keyword density tool. Specifically useful when parsing large, dense job descriptions against several pattern variants, preventing repeated setup operations.
🔬 Measurement: Ensure all tests across
tests/test_keyword_density.pypass and execution completes without performance regressions in standard use. Runpython -m pytest tests/to confirm.PR created automatically by Jules for task 3605191710944001867 started by @anchapin