🛡️ Sentinel: [CRITICAL] Fix RCE and DoS risks in Cover Letter PDF Compilation

[anchapin]

🚨 Severity: CRITICAL
💡 Vulnerability: CoverLetterGenerator._compile_pdf executed pdflatex and pandoc without -no-shell-escape flags and without subprocess timeouts. This allowed an attacker submitting a malicious LaTeX payload to execute arbitrary shell commands (RCE) or stall the backend via infinite loops.
🎯 Impact: Remote code execution, Denial of service.
🔧 Fix: Added -no-shell-escape to both LaTeX engines and implemented a 30 second subprocess timeout using communicate(timeout=30) with safe termination inside a try/catch block.
✅ Verification: python -m pytest tests/test_pdf_security.py passes successfully.

---

PR created automatically by Jules for task 11261639235760785875 started by @anchapin

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery