⚡ Bolt: [performance improvement] Optimize Regex Compilation in job_parser.py

[anchapin]

💡 What: Hoisted frequently used regex patterns (_INDEED_HEADER_PATTERN, _REQUIREMENTS_HEADING_PATTERN, and _RESPONSIBILITIES_HEADING_PATTERN) to module-level constants in cli/integrations/job_parser.py.
🎯 Why: Previously, re.compile() was being called inside _parse_indeed, _parse_generic, and _extract_list_by_keyword every time they were executed. This caused unnecessary compilation overhead during HTML parsing.
📊 Impact: Reduces the overhead of parsing a job post by pre-compiling static regex expressions once at module load time.
🔬 Measurement: Verified by running python -m pytest tests/test_job_parser.py tests/test_job_parser_integration.py successfully.

---

PR created automatically by Jules for task 7390426673691145918 started by @anchapin

Summary by Sourcery

Optimize performance of job parsing and CLI conversion by hoisting repeated computations into module-level constants and improving type handling.

Enhancements:

• Pre-compile frequently used regex patterns in job_parser to avoid repeated compilation during HTML parsing.
• Allow _extract_list_by_keyword to accept either plain strings or pre-compiled regex patterns for more flexible and efficient matching.
• Replace repeated YAML extension list literals in convert CLI with a shared module-level constant for reuse and clarity.

Documentation:

• Document lessons learned about regex pre-compilation and ineffectiveness of micro-optimizing constant membership checks in .jules/bolt.md.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's Guide

Hoists hot-path regex compilations in the job parser to module-level constants and slightly refactors a list-based extension check in the CLI into a shared constant, while updating the internal Bolt notes to reflect these learnings.

Updated class diagram for job_parser regex optimization

classDiagram
    class JobParserModule {
        +_INDEED_HEADER_PATTERN: Pattern
        +_REQUIREMENTS_HEADING_PATTERN: Pattern
        +_RESPONSIBILITIES_HEADING_PATTERN: Pattern
    }

    class JobParser {
        +_parse_indeed(html: str): JobDetails
        +_parse_generic(html: str): JobDetails
        +_extract_list_by_keyword(html: str, keyword: Union[str, Pattern]): List[str]
    }

    JobParser --> JobParserModule : uses

Loading

Updated class diagram for convert CLI YAML extension handling

classDiagram
    class ConvertModule {
        +_YAML_EXTENSIONS: Set[str]
        +convert(input_file: Path, output_file: Path, direction: str, format: str, no_overwrite: bool): None
        +import_resume(input_file: Path, fmt: Optional[str], output: Optional[Path]): None
        +export_resume(input_file: Path, fmt: Optional[str], output: Optional[Path]): None
    }

Loading

File-Level Changes

Change	Details	Files
Pre-compile frequently used regex patterns in job_parser to avoid repeated compilation in hot paths.	Introduce module-level compiled regex constants for Indeed header, requirements headings, and responsibilities headings. Replace inline re.compile calls in _parse_indeed and _parse_generic with the precompiled regex constants, adding type: ignore annotations for BeautifulSoup typing issues. Adjust _extract_list_by_keyword to accept either a string or compiled regex, normalize to a pattern once per call, and reuse that for BeautifulSoup searches.	cli/integrations/job_parser.py
Introduce a shared constant for YAML file extensions in convert CLI and reuse it across commands.	Define a module-level _YAML_EXTENSIONS set of supported YAML suffixes. Replace repeated inline list literals used for YAML extension membership checks in convert, import_resume, and export_resume with the shared constant.	cli/commands/convert.py
Document the lessons learned about regex pre-compilation and micro-optimizations in Bolt documentation.	Add a Bolt log entry describing regex pre-compilation benefits in hot paths. Add a Bolt log entry explaining why converting simple constant membership checks to sets is a non-beneficial micro-optimization and where to focus performance efforts instead.	.jules/bolt.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In convert.py, the _YAML_EXTENSIONS set and its accompanying performance comment conflict with the note in .jules/bolt.md about membership checks already being optimized by CPython; consider reverting to the original literal and dropping the micro-optimization comment to keep the code and guidance consistent.
• Now that _extract_list_by_keyword accepts a Pattern, you could pass precompiled regexes from the call sites that use fixed keywords (e.g., for requirements/responsibilities) to avoid repeated re.compile calls there as well.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `convert.py`, the `_YAML_EXTENSIONS` set and its accompanying performance comment conflict with the note in `.jules/bolt.md` about membership checks already being optimized by CPython; consider reverting to the original literal and dropping the micro-optimization comment to keep the code and guidance consistent.
- Now that `_extract_list_by_keyword` accepts a `Pattern`, you could pass precompiled regexes from the call sites that use fixed keywords (e.g., for requirements/responsibilities) to avoid repeated `re.compile` calls there as well.

## Individual Comments

### Comment 1
<location path="cli/commands/convert.py" line_range="16-17" />
<code_context>

 from ..utils.json_resume_converter import JSONResumeConverter, convert_yaml_to_json_resume

+# Optimize file extension checks with O(1) set lookup to prevent repeated list allocations
+_YAML_EXTENSIONS = {".yaml", ".yml"}
+

</code_context>
<issue_to_address>
**suggestion:** The optimization comment overstates the impact and may be misleading.

Using a set literal here is fine, but the performance impact in this CLI context is negligible. The current comment implies a significant optimization that doesn’t really occur and could mislead future readers. Please either remove the optimization framing or rephrase it to something neutral like `# Supported YAML file extensions` to focus on semantics rather than micro-optimization.

```suggestion
# Supported YAML file extensions
_YAML_EXTENSIONS = {".yaml", ".yml"}
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: The optimization comment overstates the impact and may be misleading.

Using a set literal here is fine, but the performance impact in this CLI context is negligible. The current comment implies a significant optimization that doesn’t really occur and could mislead future readers. Please either remove the optimization framing or rephrase it to something neutral like # Supported YAML file extensions to focus on semantics rather than micro-optimization.

Suggested change

	# Optimize file extension checks with O(1) set lookup to prevent repeated list allocations
	_YAML_EXTENSIONS = {".yaml", ".yml"}
	# Supported YAML file extensions
	_YAML_EXTENSIONS = {".yaml", ".yml"}