🛡️ Sentinel: [CRITICAL] Fix LaTeX RCE and DoS vulnerability in PDF generation

[anchapin]

🚨 Severity: CRITICAL
💡 Vulnerability: Remote Code Execution (RCE) via pdflatex and pandoc allowing shell escapes, and Denial of Service (DoS) via missing timeouts on subprocess.communicate().
🎯 Impact: Malicious user input (or AI-hallucinated LaTeX) containing \write18{...} could execute arbitrary system commands on the host. Malicious or malformed LaTeX could also cause infinite compilation loops, consuming all CPU resources.
🔧 Fix: Enforced the -no-shell-escape flag for all pdflatex and pandoc (via --pdf-engine-opt) calls in cli/pdf/converter.py and cli/generators/cover_letter_generator.py. Implemented a 30-second timeout with proper process.kill() cleanup.
✅ Verification: Code review confirmed flags are added. Tested locally via python -m pytest tests/ which all pass.

---

PR created automatically by Jules for task 15770832289820726946 started by @anchapin

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery