🛡️ Sentinel: [CRITICAL] Fix Remote Code Execution in PDF generation#327
🛡️ Sentinel: [CRITICAL] Fix Remote Code Execution in PDF generation#327anchapin wants to merge 1 commit into
Conversation
Added `-no-shell-escape` flag to all `pdflatex` and `pandoc` subprocess calls to prevent arbitrary command execution via `\write18` malicious input. Implemented 30s timeouts and explicit process cleanup to prevent infinite compilation loops (DoS vector). Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Unsafe subprocess calls to LaTeX compilers (
pdflatex,pandoc) permitted arbitrary shell command execution (\write18) if evaluating untrusted text. Subprocess calls lacked timeouts and explicit process cleanup, creating a potential Denial of Service (DoS) and zombie process vectors when encountering hanging or malicious LaTeX documents.🎯 Impact: Allowed Remote Code Execution (RCE) on the server handling PDF compilation, potentially compromising entire systems.
🔧 Fix: Added
-no-shell-escapeflags directly topdflatex(-no-shell-escape) andpandoc(--pdf-engine-opt=-no-shell-escape) incli/generators/cover_letter_generator.pyandcli/pdf/converter.py. Added explicit timeouts (timeout=30) and process cleanup mechanisms (process.kill(),process.communicate()) to prevent zombies.✅ Verification: Verified by passing all test suites and specific security tests (
test_pdf_security.py). Runbandit -r cli/ -x tests/to confirm.PR created automatically by Jules for task 1243005084294333709 started by @anchapin