S3 Upload Update

[ArtyDaSmarty]

I saw why now that complete S3 conversion would be wayyy too much to just code for the sake of it, so instead, I made it so at least images can be stored, if the Admin permits, onto a S3 instance. All functions SEEM fine from testing, but if you find any hiccups, please let me know!

[ancsemi]

This is even more 😂

It'll take me a while to go through it. I'll keep the PR open til I get around to it, but I'd like to focus on bug fixes and smaller QoL before adding such a big mod!

Stay tuned!

[ArtyDaSmarty]

Wanted to let it be known as of now, it has been thoroughly tested and seems to be working with no issues ^w^

[Jaymus3]

Can you try to add meaningful commit messages, or code comments? This is an enormous diff to review and has some misc. edits with no clear justification, like updating the node version to 22. Even if you don't have a full understanding of what the commit is accomplishing, asking the agent you're working with to write a description would help a lot.

[ArtyDaSmarty]

@Jaymus3

I can definitely attempt! I sort of removed the old project to add the new version of the merged repository on Codex (I know there was probably an easier way looking back on it). If I can't and it's just too much trouble, I can easily close the pull request ^w^

I was trying to get a fork up so I could edit what I want without messing with Zeabur files and propose stuff to the actual Haven when I trust it is stable. I apologize for not considering how much looking through would need to be done.

[Jaymus3]

Instead of scrapping the PR, you could amend your commits with descriptions and force push to your branch. That should update the PR as well. In addition to that, a single commit that just adds comments in certain areas would make this so much easier to parse if you're willing to go the extra mile.

[ArtyDaSmarty]

I am going to see if my Agent can properly get notes/explanations out, as when it came to S3, unlike my other PR where I had a WAYYY better grasp, 90% of this was the Agent. I kept messing with it until it worked during testing properly with no errors or issues that I or others could see during use (like attachment errors, S3 not working, etc).

[ArtyDaSmarty]

This is what the Agent has told me regarding it's changes. Again, I did this fork mostly to add things to my own instance and offer them up to the main Haven repository, so I apologize I did not do a more organized method to make review easier. I will keep it noted for the future so my PRs can actually be reviewed.

I will attempt to try and get something pushed to comment on all the changed code, but it may take too long for most people's liking, as I am not reliable on time ;-;