Support REGEXP BINARY #817
Open
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
django use in mysql dialect the "REGEXP BINARY" compare operator.
Add tests for REGEXP and REGEXP BINARY SQL syntax.
Removed comments referencing issue 369 from test_regexp and test_regexp_binary functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Before submitting your pull request please have a look at the
following checklist:
pytest)flake8)We use Django 4.2 and require sqlparse for parsing the SQL Query. (As part of the djongo library, we migrated to latest django version)
Now we got an error, by using case sensitive regex filter like "columnname REGEXP BINARY 'static.+[0-9]+'
I wasn't aware of such operator, but it exists and is used by Django, when regex must be case sensitive.
So I prepare a PR to implement support for this compare operator.
I'm not fully sure about the "\b" at the end, but it was there and probably it prevents to recognize something like "REGEXP binarystring" as operator. (Also when it isn't valid sql)
I'm open to adjust when something feels strange.