Skip to content

Add translations for Newsletter #36 and topic pages - #137

Merged
Datawav merged 3 commits into
mainfrom
translate/2026-08-19
Aug 20, 2026
Merged

Add translations for Newsletter #36 and topic pages#137
Datawav merged 3 commits into
mainfrom
translate/2026-08-19

Conversation

@Datawav

@Datawav Datawav commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Translations for Newsletter #36 (2026-08-19)

Translates:

References: #135

Languages: de, es, fr, it, ja, ko, nl, pt, zh

Character encoding verified ✓
Technical terms preserved ✓
Internal links verified ✓

Test plan

  • Hugo build passes for all locales
  • Translation verifier passes for all nine locales
  • Internal newsletter and topic links resolve
  • Newsletter style checks and repository unit tests pass

Translates Newsletter #36 (2026-08-19) to de, es, fr, it, ja, ko, nl, pt, zh.
All 30 referenced topic pages already existed per language.
References: #135

Co-authored-by: Cursor <cursoragent@cursor.com>
@Datawav

Datawav commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

Translation review (task t_fe4f7755)

Automated audit + source comparison against content/en/newsletters/2026-08-19-newsletter.md.

PASS

  • All 9 locale newsletter files present (de, es, fr, it, ja, ko, nl, pt, zh)
  • Frontmatter complete: translationOf, translationDate, publishDate, description
  • Section structure matches EN (6× H2, 29× H3 per locale)
  • 30 internal /{lang}/topics/ links each; all target files exist; no NIP XX→nip-YY mismatches
  • JSON event examples unchanged vs EN; check_newsletter_event_examples.py PASS on all 9 files
  • No /en/ locale leaks; external GitHub URLs otherwise preserved
  • Hugo build CI: SUCCESS

Must fix before merge

Broken Divine Mobile release URLs (404) — EN uses .../releases/tag/1.0.20 (verified on GitHub). Eight locales changed this to v1.0.20:

  • Affected: es, fr, it, ja, ko, nl, zh (3 links each); pt (2 of 3 links)
  • de is correct throughout

Replace v1.0.201.0.20 in every Divine Mobile release link.

Should fix (quality)

  • Untranslated section headings: de and nl keep English ## Releases and ## NIP Deep Dive while other locales translate these (e.g. es “Versiones”, zh “版本发布”).
  • Korean-only extra link: ko adds [NIP-7D](https://github.com/nostr-protocol/nips/blob/master/7D.md) on the PR #2436 paragraph; EN names NIP-7D inline without that URL. Optional consistency fix.

Note (non-blocking, #35 dependency)

Back-references to / {lang}/newsletters/2026-08-12-newsletter/#amber-640-... and #divine-mobile-1019-... use English anchor slugs. Newsletter #35 exists in EN only on main; localized #35 pages are tracked separately. Links will 404 until that backlog lands — same pattern as prior translation PRs.

Verdict: Request changes for the Divine Mobile release-tag regression; re-review after fix.

Replace broken v1.0.20 GitHub release links with tag/1.0.20 in eight
locale newsletter files per translation review on PR #137.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Datawav

Datawav commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

Translation re-review (task t_d38c0897)

Independent audit of HEAD 131d45b after the Divine Mobile URL fix.

PASS

  • All 9 locale newsletter files present and scoped to Newsletter Update Dockerfile to use hugomods/hugo:dart-sass-git #36 only (no Add Newsletter #3 and topic translations for 9 languages #35 backlog in diff)
  • Blocking regression fixed: no divine-mobile/releases/tag/v1.0.20 links remain; all use tag/1.0.20 matching EN/GitHub
  • Section structure matches EN (6× H2, 29× H3); 30 internal /{lang}/topics/ links each; all topic pages exist; no NIP XX→nip-YY mismatches
  • JSON event examples byte-identical to EN; check_newsletter_event_examples.py PASS on all 9 files
  • check_newsletter_style.py PASS on all 9 files; no /en/ locale leaks in translated files
  • Hugo build CI: SUCCESS on 131d45b

Non-blocking quality notes (same as prior review)

  • de and nl still use English ## Releases and ## NIP Deep Dive while other locales translate these headings
  • ko adds an extra [NIP-7D](https://github.com/nostr-protocol/nips/blob/master/7D.md) link on the PR #2436 paragraph; EN names NIP-7D inline without that URL
  • Back-references to #35 newsletter anchors use English slug fragments until localized Add Newsletter #3 and topic translations for 9 languages #35 pages land (known backlog; not introduced by this PR)

Verdict: Approve. Substantiated blocking defect is resolved; remaining items are optional consistency polish.

@Datawav
Datawav merged commit d2b25d8 into main Aug 20, 2026
2 checks passed
@Datawav
Datawav deleted the translate/2026-08-19 branch August 20, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant