Fix local dev setup: Docker mount footgun, missing prerequisites docs - #23
Open
ifuensan wants to merge 2 commits into
Open
Fix local dev setup: Docker mount footgun, missing prerequisites docs#23ifuensan wants to merge 2 commits into
ifuensan wants to merge 2 commits into
Conversation
- justfile: dev-up now creates data/relay-stats.db before docker compose up, preventing Docker from creating it as a root-owned directory (which broke the ingester's RocksDB dedupe index with PermissionDenied) - README: add Prerequisites section (Rust >= 1.90, protoc, just, Docker) - .gitignore: ignore segments/ (default ingester output directory) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The documented Quick Start ran `docker compose up -d` directly, bypassing the relay-stats.db pre-creation guard in `just dev-up` and leaving the root-owned-directory footgun reachable through the documented path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
dev-upensuresdata/relay-stats.dbexists beforedocker compose up. Grafana bind-mounts this file; on a fresh clone Docker creates the missing path as a root-owned directory, which later breaks the ingester withPermissionDeniedon RocksDB.just dev-upinstead of rawdocker compose up -d, so the documented path goes through the same guard.protoc,just, Docker).protocis required by thepensieve-corebuild script but wasn't documented.segments/(created by the Quick Start command).Impact
A fresh clone now goes from
git cloneto a working local dev environment by following the README.Verification
just precommitpassesdev-up→ migrations → live ingestion with Grafana dashboards populatedReviewer note:
pensieve-deploy/docker-compose.ymlhas the same single-file bind mount for/data/relay-stats.db, and the deploy README's directory-setup section doesn't pre-create it — same latent footgun on a fresh production deploy. Left out of scope here; happy to open a separate issue.🤖 Generated with Claude Code