Skip to content

Expenses Calendar Heatmap #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Evernight
Copy link

One of the charts I found useful to check how expenses are spread across the month/year, also to find some transactions more easily.

I meant to regenerate screenshots with make container-test-js-update to avoid screenshots in a dark mode but wasn't able to build a Docker image with:

Error: ERROR: Failed to set up chrome v133.0.6943.53! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.

Tried to update puppeteer to 24.7.2 but got same message with a different version of chrome.
Figured it's better to confirm if it builds normally on your side @andreasgerstmayr and if the issue is in my local setup.

@andreasgerstmayr
Copy link
Owner

Tried to update puppeteer to 24.7.2 but got same message with a different version of chrome. Figured it's better to confirm if it builds normally on your side @andreasgerstmayr and if the issue is in my local setup.

I recently switched to a Mac (ARM architecture) and now I also can't run the e2e tests anymore (puppeteer/puppeteer#10172, docker/for-mac#5766). I think I'll have to switch to Cypress, they provide official docker images with Chrome for amd64 and arm.

Regardless of the e2e tests, I tried your PR and it looks nice! One question: It does only display a single year, while the timeframe spans multiple years (as seen in the "Savings Heatmap" chart for example). Can you duplicate the graph for every year?

@Evernight
Copy link
Author

@andreasgerstmayr ah, I see. I'm on Mac as well. I'll try switching the global theme and regenerating the screenshots. Will see if preserving the locale settings is also necessary and possible.

Thanks for taking a look and the feedback!
I wanted to keep it compact and simple so I ended up with a simple heuristic that charts just a single year. However indeed it's worth at least trying to see what it will look like if there are multiple years displayed at the same time. Will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants