[TASK] Use Rector 2.0 #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonschaufi
force-pushed
the
rector-2
branch
2 times, most recently
from
6edfaa7 to
04b0fe3
Compare
simonschaufi
force-pushed
the
rector-2
branch
2 times, most recently
from
ff8932e to
d363dda
Compare
andreaswolf
reviewed
Apr 2, 2025
| @@ -13,7 +13,7 @@ | |||
| interface TypoScriptNodeVisitor | |||
| { | |||
| /** | |||
| * @param list<Statement> $statements | |||
There was a problem hiding this comment.
list<Statement> has different (stronger) semantics than Statement[] – the former is an indexed list, the latter is just an array w/o revealing anything about the keys. Are we sure we want this change here? Or is it PhpStan complaining for some reason?
Comment on lines
+20
to
+22
| ignoreErrors: | ||
| - identifier: return.unusedType | ||
| - identifier: varTag.nativeType |
There was a problem hiding this comment.
Why these ignores? I'm not exactly fond of ignoring whole classes of errors for the whole project…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.