Added support for including assets by relative path in bundle.txt #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed superfluous allocation from BundleFactoryBase.CreateBundle
Call relative path populate for add multiple subfolders
|
Any chance of getting this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you don't want to move files around into different directories to be able to create a bundle with them. For example, if you're pulling in jQuery via nuget, you probably want to leave the .js in ~/Scripts and create a jQuery bundle that references that .js and an external CDN url.
Before, adding files by directory (which was used for bundle.txt) only added files in that package directory, even if the bundle.txt included relative paths to other files (like ~/Scripts/jquery-1.11.0.js). I added an extra check on add to ensure that allFiles is properly populated with relative path references from Assets.
I also removed a couple of extra allocations done by unneeded .ToArray() calls.
This also fixes #244.