Add KeyAttestationReason to CertPathValidatorException. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_805800611
branch
10 times, most recently
from
4433292 to
a770f57
Compare
copybara-service
bot
force-pushed
the
test_805800611
branch
2 times, most recently
from
7f16a7f to
b1c9203
Compare
copybara-service
bot
force-pushed
the
test_805800611
branch
6 times, most recently
from
7b9d72b to
5439d7e
Compare
copybara-service
bot
force-pushed
the
test_805800611
branch
4 times, most recently
from
8d3827d to
d3c4d53
Compare
copybara-service
bot
force-pushed
the
test_805800611
branch
2 times, most recently
from
ebc67cf to
5bd653b
Compare
copybara-service
bot
force-pushed
the
test_805800611
branch
from
5bd653b to
41cc2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KeyAttestationReason to CertPathValidatorException.
This will allow callers to distinguish between different errors in the
chain without string matching. This requires explicitly stating the
required API for each method which diretly or indirectly uses
KeyAttestationReason, but shouldn't be an actual change in requirements
since the other reasons also require API 24 when used on Android.
This also moves the key attestation chain format checks to be
exclusively in the validator instead of some of them being duplicated
in the KeyAttestationCertPath constructor. The validator checks could
previously never be executed and the CertPathValidatorException allows
for more structured information returned on exception.