RTSP H265 Aggregation packet support #2413
Conversation
|
Hi @tonihei, could you please help with review and moving forward with the change? |
| int endOfData = data.bytesLeft(); | ||
| int currentPosition = 2; // skipping payload header (2 bytes) | ||
| do { | ||
| int nalUnitSize = ((data.getData()[currentPosition] & 0xFF) << 8) |
There was a problem hiding this comment.
Is this equivalent to data.readUnsignedShort()?
|
Hi @microkatz thank you for review and comment, could you please review again? |
ParsableByteArray operations utilized instead of manual bytes manipulation
Got read of endOfData variable in favor of check based on bytesLeft
microkatz
force-pushed
the
rtap-h265-aggregation-packet-support
branch
from
68d2c66 to
af67e05
Compare
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
|
Would you be able to add a test for this? I believe that you would create a file and test similar to the one in RtpH263ReaderTest. Thank you! |
| data.setPosition(2); // skipping payload header (2 bytes) | ||
| do { | ||
| short nalUnitSize = data.readShort(); // 2 bytes of NAL unit size | ||
| int nalHeaderType = (data.getData()[data.getPosition()] >> 1) & 0x3F; |
There was a problem hiding this comment.
I believe the data.getData()[data.getPosition()] would be data.peekUnsignedByte().
Or the whole line as NalUnitUtil.getH265NalUnitType(data.getData(), -3).
| trackOutput.sampleData(data, nalUnitSize); | ||
| fragmentedSampleSizeBytes += nalUnitSize; | ||
| bufferFlags = getBufferFlagsFromNalType(nalHeaderType); | ||
| } while (data.bytesLeft() > 0); |
There was a problem hiding this comment.
You could also make this a while loop such that while(data.bytesLeft() >= 3)
There was a problem hiding this comment.
That is correct, however in this case we may miss "invalid" packet with 1-2 bytes "extra"
Yes, sure, I can add tests for that |
Aggregation packet support for H265 RTSP added according to the specification.
The implementation is based on the assumption that DONL won't be present in the packet since
sprop-max-don-diff != 0is not supportedFixes issue: #1008