Retain linux-firmware basename #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files in linux-firmware are symlinks, so when we extract them into a smaller derivation, we should retain the same filename to ensure a driver needing firmware is able to find the right file. The `install` tool will dereference the symlink and use the symlink's basename to ensure we get the right content at the right location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Some files in linux-firmware are symlinks, so when we extract them into a smaller derivation, we should retain the same filename to ensure a driver needing firmware is able to find the right file. The
installtool will dereference the symlink and use the symlink's basename to ensure we get the right content at the right location.Testing
Tested building a nixos config's
config.hardware.firmwarefor an orin-nx and confirmed that all the correct rtl nic firmware was present